Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow rule create with no distributions; update imports #759

Merged
merged 1 commit into from
Mar 20, 2022

Conversation

markphelps
Copy link
Collaborator

Fixes: #758

Screen Shot 2022-03-20 at 1 13 26 PM

  • Disallow rule to be created with no variants/distributions in UI
  • Fix small issue where clicking 'Choose Variants' again didnt clear our distributions
  • Update imports from lodash to use ES6 style

@markphelps markphelps enabled auto-merge (squash) March 20, 2022 17:18
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2022

Codecov Report

Merging #759 (12f5588) into master (549104c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #759   +/-   ##
=======================================
  Coverage   82.56%   82.56%           
=======================================
  Files          19       19           
  Lines        1709     1709           
=======================================
  Hits         1411     1411           
  Misses        249      249           
  Partials       49       49           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 549104c...12f5588. Read the comment docs.

@markphelps markphelps merged commit 8ca6e39 into master Mar 20, 2022
@markphelps markphelps deleted the fix-empty-rules-ui branch March 20, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't allow empty rules to be created in UI
2 participants