JMSSampler - Use Response Message Id #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrizio
changed the title
timkoopmans
reviewed
May 2, 2017
| @@ -20,6 +20,7 @@ def initialize(params={}) | |||
| <boolProp name="JMSSampler.isFireAndForget">true</boolProp> | |||
| <boolProp name="JMSSampler.isNonPersistent">false</boolProp> | |||
| <boolProp name="JMSSampler.useReqMsgIdAsCorrelId">false</boolProp> | |||
| <boolProp name="JMSSampler.useResMsgIdAsCorrelId">false</boolProp> | |||
There was a problem hiding this comment.
any files in dsl/* are auto generated by IDL so this line will get overwritten next time IDL is run. Better to add it to idl.xml (open it in jmeter) so that your change will persist.
timkoopmans
reviewed
May 2, 2017
| @@ -597,6 +597,7 @@ | |||
| <boolProp name="JMSSampler.isFireAndForget">true</boolProp> | |||
| <boolProp name="JMSSampler.isNonPersistent">false</boolProp> | |||
| <boolProp name="JMSSampler.useReqMsgIdAsCorrelId">false</boolProp> | |||
| <boolProp name="JMSSampler.useResMsgIdAsCorrelId">false</boolProp> | |||
There was a problem hiding this comment.
ahh cool you already did - sorry missed this commit
There was a problem hiding this comment.
No worries - thanks. It's a fantastic gem - keep up the good work!
|
Tagged and released v3.1.01 with this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing Use Response Message Id field XML entry to idl.XML