Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cache clean policy #2527

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cheyang
Copy link
Collaborator

@cheyang cheyang commented Jan 27, 2023

Signed-off-by: cheyang cheyang@163.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #2526

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: cheyang <cheyang@163.com>
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Jan 27, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from cheyang by writing /assign @cheyang in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #2527 (68c2b9d) into master (7c5661a) will increase coverage by 0.00%.
The diff coverage is 67.74%.

❗ Current head 68c2b9d differs from pull request most recent head 6b01e70. Consider uploading reports for the commit 6b01e70 to get more accurate results

@@           Coverage Diff           @@
##           master    #2527   +/-   ##
=======================================
  Coverage   67.55%   67.55%           
=======================================
  Files         367      368    +1     
  Lines       21267    21298   +31     
=======================================
+ Hits        14366    14387   +21     
- Misses       5218     5224    +6     
- Partials     1683     1687    +4     
Impacted Files Coverage Δ
pkg/ddc/alluxio/transform_clean_cache_policy.go 66.66% <66.66%> (ø)
pkg/ddc/alluxio/transform.go 61.95% <100.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Set default value for clean cache policy
1 participant