Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This pr is to add license to ./pkg/common/constants.go #4056

Merged
merged 8 commits into from
May 30, 2024

Conversation

melldy
Copy link
Contributor

@melldy melldy commented May 8, 2024

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: melldy <miyue816@163.com>
Copy link

fluid-e2e-bot bot commented May 8, 2024

Hi @melldy. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

melldy added 7 commits May 8, 2024 10:38
Signed-off-by: melldy <miyue816@163.com>
Signed-off-by: melldy <miyue816@163.com>
Signed-off-by: melldy <miyue816@163.com>
Signed-off-by: melldy <miyue816@163.com>
Signed-off-by: melldy <miyue816@163.com>
Signed-off-by: melldy <miyue816@163.com>
Signed-off-by: melldy <miyue816@163.com>
Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@melldy
Copy link
Contributor Author

melldy commented May 16, 2024

/assign @cheyang thanks

Copy link

fluid-e2e-bot bot commented May 16, 2024

@melldy: GitHub didn't allow me to assign the following users: thanks.

Note that only fluid-cloudnative members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @cheyang thanks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LiYuhang9527
Copy link
Contributor

/lgtm

Copy link

fluid-e2e-bot bot commented May 21, 2024

@LiYuhang9527: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@TrafalgarZZZ TrafalgarZZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

fluid-e2e-bot bot commented May 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TrafalgarZZZ TrafalgarZZZ merged commit 39d1bd9 into fluid-cloudnative:master May 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants