Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to disable metadata sync for thinruntime #4091

Conversation

TrafalgarZZZ
Copy link
Member

Ⅰ. Describe what this PR does

By setting ThinRuntime.spec.management.metadataSyncPolicy.autoSync=false, users may disable metadata sync if that is not required.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.1% Duplication on New Code

See analysis details on SonarCloud

@TrafalgarZZZ
Copy link
Member Author

/test fluid-e2e

@TrafalgarZZZ
Copy link
Member Author

/retest

7 similar comments
@TrafalgarZZZ
Copy link
Member Author

/retest

@TrafalgarZZZ
Copy link
Member Author

/retest

@TrafalgarZZZ
Copy link
Member Author

/retest

@TrafalgarZZZ
Copy link
Member Author

/retest

@TrafalgarZZZ
Copy link
Member Author

/retest

@TrafalgarZZZ
Copy link
Member Author

/retest

@TrafalgarZZZ
Copy link
Member Author

/retest

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

fluid-e2e-bot bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TrafalgarZZZ
Copy link
Member Author

/retest

@fluid-e2e-bot fluid-e2e-bot bot merged commit 454abf6 into fluid-cloudnative:master May 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants