feat: show application as soon as possible #1499
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrolamas
added
FR - Enhancement
pedrolamas
force-pushed
the
pedrolamas/early-app-init
branch
from
9d00086
to
cc4e2cf
Compare
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
pedrolamas
force-pushed
the
pedrolamas/early-app-init
branch
from
cc4e2cf
to
c1ccdbf
Compare
|
I tested the changes and they look fine to me (at least nothing appears to be broken 😛), but just wondering: is this solving any specific issue? I haven't noticed fluidd taking "too long" to load or anything - I believe it's always shown the app even if the socket wasn't connected yet? |
|
The current behavior is to try and connect the socket before we even show the UI, and that translates in a 3s delay if the address is down. The new behavior is to show the page with an "indeterminate" progress bar loading while we do the connection.
On the above, left is new behavior, right is the old behavior. I pressed F5 on both sides at the same time. |
matmen
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Present Fluidd page as soon as possible instead of waiting for socket connection.
The changes here are significant and could lead to unexpected scenarios, but I have tested with and without authentication enabled and I believe everything is working as it should and no errors are currently being logged in the browser console.
Signed-off-by: Pedro Lamas pedrolamas@gmail.com