-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive Demo [Material 3 Reply App] #1214
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domesticmouse
requested changes
Dec 11, 2022
CI Issues: Analyzing material3-reply...
info - lib/widgets/email_widget.dart:103:65 - The 'child' argument should be last in widget constructor invocations. Try moving the argument to the end of the argument list. - sort_child_properties_last
info - lib/widgets/email_widget.dart:103:72 - Use 'const' with the constructor to improve performance. Try adding the 'const' keyword to the constructor invocation. - prefer_const_constructors
info - lib/widgets/email_widget.dart:109:65 - The 'child' argument should be last in widget constructor invocations. Try moving the argument to the end of the argument list. - sort_child_properties_last
info - lib/widgets/email_widget.dart:109:72 - Use 'const' with the constructor to improve performance. Try adding the 'const' keyword to the constructor invocation. - prefer_const_constructors
4 issues found. |
@domesticmouse thanks for the ping. I think that 56e5fd5 should fix those analyzer errors. |
And yet more errors. Please run |
domesticmouse
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out-of-the-box adaptive layouts were the most requested feature on desktop platforms in the Q3 2022 survey. The M3 Reply App is a good example of an app that adapts. This PR contains an implementation of the app.
kuhtyctp-Adaptive.Hero.-.3P.1.mp4
Screen.Recording.2022-12-09.at.10.14.03.AM.mov
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.