Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive Demo [Material 3 Reply App] #1214

Merged
merged 7 commits into from
Dec 13, 2022
Merged

Conversation

a-wallen
Copy link
Contributor

@a-wallen a-wallen commented Dec 9, 2022

Out-of-the-box adaptive layouts were the most requested feature on desktop platforms in the Q3 2022 survey. The M3 Reply App is a good example of an app that adapts. This PR contains an implementation of the app.

kuhtyctp-Adaptive.Hero.-.3P.1.mp4
Screen.Recording.2022-12-09.at.10.14.03.AM.mov

Pre-launch Checklist

  • I read the Effective Dart: Style recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

material3-reply/lib/models/name.dart Outdated Show resolved Hide resolved
material3-reply/lib/animation/constants.dart Show resolved Hide resolved
material3-reply/test/widget_test.dart Outdated Show resolved Hide resolved
@domesticmouse
Copy link
Contributor

CI Issues:

Analyzing material3-reply...

   info - lib/widgets/email_widget.dart:103:65 - The 'child' argument should be last in widget constructor invocations. Try moving the argument to the end of the argument list. - sort_child_properties_last
   info - lib/widgets/email_widget.dart:103:72 - Use 'const' with the constructor to improve performance. Try adding the 'const' keyword to the constructor invocation. - prefer_const_constructors
   info - lib/widgets/email_widget.dart:109:65 - The 'child' argument should be last in widget constructor invocations. Try moving the argument to the end of the argument list. - sort_child_properties_last
   info - lib/widgets/email_widget.dart:109:72 - Use 'const' with the constructor to improve performance. Try adding the 'const' keyword to the constructor invocation. - prefer_const_constructors

4 issues found.

@a-wallen
Copy link
Contributor Author

@domesticmouse thanks for the ping. I think that 56e5fd5 should fix those analyzer errors.

@domesticmouse
Copy link
Contributor

And yet more errors. Please run dart format on the code, it's enforced by the CI.

@domesticmouse domesticmouse merged commit 6b40078 into flutter:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants