Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webview-flutter] Added step 03: Getting Started #198

Merged

Conversation

JDDV
Copy link
Contributor

@JDDV JDDV commented Oct 21, 2021

Added the 'Getting Started' code for the webview_flutter codelab (codelab is WIP).
This step contains setting up a flutter project and update the gradle.build.

Pre-launch Checklist

  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@google-cla google-cla bot added the cla: yes label Oct 21, 2021
@@ -0,0 +1,16 @@
# step_03
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete please

webview_flutter/step_03/analysis_options.yaml Show resolved Hide resolved
@domesticmouse
Copy link
Contributor

Please add the CI integration change to this PR, as this is the PR I will land first. That will force the test suites on the later steps to be modified to pass before they can land. =)

@google-cla
Copy link

google-cla bot commented Oct 26, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Oct 26, 2021
@mvanbeusekom
Copy link

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Oct 26, 2021
@domesticmouse domesticmouse merged commit 874d44f into flutter:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants