Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updated code samples for the "Getting started" codelab #279

Merged
merged 1 commit into from
Feb 15, 2022
Merged

fix: Updated code samples for the "Getting started" codelab #279

merged 1 commit into from
Feb 15, 2022

Conversation

albertodev01
Copy link
Contributor

This is another attempt for this PR which requires these files to be updated as well

Pre-launch Checklist

  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

@albertodev01 albertodev01 mentioned this pull request Feb 9, 2022
Closed
3 tasks
craiglabenz
craiglabenz reviewed Feb 14, 2022
View reviewed changes
Copy link

@craiglabenz craiglabenz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not well-versed in the #docregion mechanic, but I do like this change for its removal of the helper method anti-pattern.

Would approve but for needing @domesticmouse's check on doc region automation.

@domesticmouse
Copy link
Contributor

This PR needs a matching PR in the website to fix things up when updating the Git sub module. I'm happy to land this PR as part of that process.

I just don't want this landed too far ahead of the fix up in flutter/website.

Adding @khanhnwin to the mix

@domesticmouse domesticmouse merged commit 24b5a12 into flutter:master Feb 15, 2022
@albertodev01 albertodev01 deleted the getting-started-update branch February 15, 2022 11:11
@albertodev01 albertodev01 mentioned this pull request Feb 15, 2022
Merged
3 tasks
@albertodev01
Copy link
Contributor Author

flutter/website#6817 let's try to get this merged too to finally close this refactor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craiglabenz craiglabenz craiglabenz left review comments

@domesticmouse domesticmouse domesticmouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albertodev01 @domesticmouse @craiglabenz