Stop passing a nullable value to Future<nn-type>.value or Completer<nn-type>.completer

[srawlins]

This is cleanup work required to start enforcing this with static analysis, as per dart-lang/sdk#53253.

Real quick this issue is that this code is unsafe:

void f(Completer<int> c, int? i) {
  Future<int>.value(i); // Ouch!
  c.complete(i);        // Ouch!
}

The typical fix is to add a null-assert (!), but sometimes a more appropriate or safer fix can be made.

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read the Flutter Style Guide recently, and have followed its advice.
• I signed the CLA.
• I listed at least one issue that this PR fixes in the description above.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or there is a reason for not adding tests.

If you need help, consider asking for help on Discord.

[kenzieschmoll]

lgtm with one suggestion