Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some ignores for nullable vlues into non-nullable Futures. #6927

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

srawlins
Copy link
Contributor

Implicitly passing a nullable value to a Future.value instantiation of a non-nullable type can lead to surprising null-asserting exceptions. See dart-lang/sdk#53253 for more details. In this PR, we add ignore, because it requires business knowledge to fix it for real.

For flutter/flutter#137294

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or there is a reason for not adding tests.

build.yaml badge

If you need help, consider asking for help on Discord.

@srawlins srawlins requested a review from a team as a code owner December 10, 2023 21:56
@srawlins srawlins requested review from kenzieschmoll and removed request for a team December 10, 2023 21:56
@srawlins srawlins merged commit c1296b1 into master Dec 11, 2023
25 of 26 checks passed
@srawlins srawlins deleted the add-ignore branch December 11, 2023 18:50
derekxu16 pushed a commit to derekxu16/devtools that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants