-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[macOS] FlutterTextInputPlugin should clip to bounds #46142
[macOS] FlutterTextInputPlugin should clip to bounds #46142
Conversation
51b9890
to
9ff515a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
auto label is removed for flutter/engine/46142, due to - The status or check suite Mac mac_clang_tidy_presubmit has failed. Please fix the issues identified (or deflake) before re-applying this label. |
9ff515a
to
0913917
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-lgtm with the clipToBounds
fix.
…135701) flutter/engine@dbb6093...cc7c3c1 2023-09-28 matej.knopp@gmail.com [macOS] FlutterTextInputPlugin should clip to bounds (flutter/engine#46142) 2023-09-28 skia-flutter-autoroll@skia.org Roll Skia from d8a71d549262 to 33502f9b0c7d (2 revisions) (flutter/engine#46375) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#135701) flutter/engine@dbb6093...cc7c3c1 2023-09-28 matej.knopp@gmail.com [macOS] FlutterTextInputPlugin should clip to bounds (flutter/engine#46142) 2023-09-28 skia-flutter-autoroll@skia.org Roll Skia from d8a71d549262 to 33502f9b0c7d (2 revisions) (flutter/engine#46375) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Fixes flutter/flutter#135219 (formerly flutter/flutter#128956) [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Fixes flutter/flutter#135219
(formerly flutter/flutter#128956)
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.