Run full clang_tidy in presubmit #48831
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm seeing post-submit runs of full clang_tidy taking about ~20-ish minutes excluding queue time, so the premise of flutter/flutter#139769 may be incorrect. In that case, we should re-enable full clang_tidy in presubmit and observe any impacts to queue time.
Context is that the clang autoroll became unblocked and landed a roll that passed clang_tidy checks in presubmit, but then failed in post submit: #48817