Fix UIButton selector doesn't work in iOS platformview #7558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! this is very helpful! I've been stumbled by this issue for some time, thank you for finding the root cause! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 23, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jan 23, 2019
…/engine#7558) (#26980) flutter/engine@1c26bf8...450c3e4 git log 1c26bf8..450c3e4 --no-merges --oneline 450c3e4 Don't accept gestures by ForwardingGestureRecognizer (flutter/engine#7558) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop the roller if necessary.
kangwang1988
pushed a commit
to XianyuTech/flutter
that referenced
this pull request
Feb 12, 2019
…/engine#7558) (flutter#26980) flutter/engine@1c26bf8...450c3e4 git log 1c26bf8..450c3e4 --no-merges --oneline 450c3e4 Don&flutter#39;t accept gestures by ForwardingGestureRecognizer (flutter/engine#7558) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Problem
When displaying a platform view in iOS without any 'GestureDetector' in flutter, the UIButton on that platform view doesn't get response.But the method 'releaseGesture' in 'FlutterTouchInterceptingView' has been executed.
2.Solution
I think the reason is that the 'ForwardingGestureRecognizer' recognize the UITouch.
In 'DelayingGestureRecognizer', it just set 'delaysTouchesBegan = YES'，so the UIButton's '- (void)touchesBegan:(NSSet<UITouch *> *)touches withEvent:(nullable UIEvent *)event' and the following method will not be executed.
@amirh Hi，I wish you can take some time for this.