Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flutter tool should print adb error #10929

Closed
mit-mit opened this issue Jun 23, 2017 · 3 comments · Fixed by #10933
Closed

Flutter tool should print adb error #10929

mit-mit opened this issue Jun 23, 2017 · 3 comments · Fixed by #10933
Assignees
@tvolkert
Labels
platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Comments

@mit-mit
Copy link
Member

mit-mit commented Jun 23, 2017

When adb fails during a flutter run, we print the non-descriptive error:

Launching lib/main.dart on Android SDK built for x86 in debug mode...
Running 'gradle assembleDebug'...                    10.5s
Built build\app/outputs/apk/app-debug.apk (21.7MB).
Installing build\app/outputs/apk/app.apk...           0.8s
Error: ADB exited with exit code 1

adb itself has more descriptive errors:

adb.exe install C:\Users\mit\tmp\app200\build\app/outputs/apk/app-debug.apk
Failed to install C:\Users\mit\tmp\app200\build\app/outputs/apk/app-debug.apk:
Failure [INSTALL_FAILED_INSUFFICIENT_STORAGE]

Can we print those?
@mit-mit mit-mit added tool Affects the "flutter" command-line tool. See also t: labels. platform-android Android applications specifically labels Jun 23, 2017
@mit-mit
Copy link
Member Author

mit-mit commented Jun 23, 2017

cc @tvolkert @jason-simmons

@tvolkert
Copy link
Contributor

Yep, we should be able to get the stderr from the process and print it upon failure.

@tvolkert tvolkert mentioned this issue Jun 23, 2017
Merged
@tvolkert tvolkert self-assigned this Jun 23, 2017
tvolkert added a commit that referenced this issue Jun 23, 2017
@tvolkert
Print ADB output when adb install fails (#10933)
f18083d 
Fixes #10929
gspencergoog pushed a commit to gspencergoog/flutter that referenced this issue Jul 1, 2017
@tvolkert @gspencergoog
Print ADB output when adb install fails (flutter#10933)
b6330b6 
Fixes flutter#10929
@github-actions
Copy link

github-actions bot commented Sep 4, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tvolkert tvolkert

Labels
platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Print ADB output when adb install fails
2 participants
@mit-mit @tvolkert