[app_extension_safe] CI Build step to build and upload extension-safe Flutter.framework #124291
Assignees
Labels
P1
High-priority issues at the top of the work list
platform-ios
iOS applications specifically
platform-mac
Building on or for macOS specifically
team-ios
Owned by iOS platform team
triaged-ios
Triaged by iOS platform team
Comments
cyanglaz
added
platform-ios
12 tasks
flutter-triage-bot
bot
added
team-ios
cyanglaz
added
P1
8 tasks
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this issue
Sep 12, 2023
Uploads the artifacts for extension safe build. These artifacts need to be codesigned. part of flutter/flutter#124291 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
8 tasks
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this issue
Sep 18, 2023
…e sign them (#45781) Generates the fat framework for extension safe variants and add them to the code sign list. Also reverts part of #45664 where the variants are uploaded in separate archive. Now with this change, the extension safe is inside a "extension_safe" folder under existing archive. fixes flutter/flutter#124291 The destination folder after this change: - An extension_safe folder is added, which includes the extension safe Flutter.frameworks and dsym - The artifacts.zip now includes the `extension_safe` except the dysm - A extension_safe_Flutter.dsym.zip is created (under ios/release/) , which includes the extension_safe/Flutter.dsym <img width="508" alt="Screenshot 2023-09-13 at 3 26 23 PM" src="https://github.com/flutter/engine/assets/3756895/84901ef1-af89-413f-94c7-74ed0aa36da6"> [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
8 tasks
jonahwilliams
pushed a commit
that referenced
this issue
Sep 20, 2023
Update the conductor to code sign extension safe iOS frameworks The new frameworks are added in https://github.com/flutter/engine/pull/45781/files part of #124291 Also includes an Engine roll includes: flutter/engine@9232e76 flutter/engine@39c0f2e ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
harryterkelsen
pushed a commit
to flutter/engine
that referenced
this issue
Oct 23, 2023
…e sign them (#45781) Generates the fat framework for extension safe variants and add them to the code sign list. Also reverts part of #45664 where the variants are uploaded in separate archive. Now with this change, the extension safe is inside a "extension_safe" folder under existing archive. fixes flutter/flutter#124291 The destination folder after this change: - An extension_safe folder is added, which includes the extension safe Flutter.frameworks and dsym - The artifacts.zip now includes the `extension_safe` except the dysm - A extension_safe_Flutter.dsym.zip is created (under ios/release/) , which includes the extension_safe/Flutter.dsym <img width="508" alt="Screenshot 2023-09-13 at 3 26 23 PM" src="https://github.com/flutter/engine/assets/3756895/84901ef1-af89-413f-94c7-74ed0aa36da6"> [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add necessary CI Steps to build the engine with the extension_safe flag (see: #124286), and upload the Flutter.framework and FlutterMacOS framework.
The extension_safe frameworks needs to be code signed
part of #124287
The text was updated successfully, but these errors were encountered: