(Update and) Integrate Rendering README into code #10389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Jun 1, 2017
| /// Update the semantics for render objects marked as needing a semantics | ||
| /// upadate. | ||
| /// | ||
| /// Initially, only the root node, as scheduled by [scheduleInitialSemantics]. |
There was a problem hiding this comment.
nit: period should be a comma
Hixie
reviewed
Jun 1, 2017
| @@ -1180,7 +1204,11 @@ class PipelineOwner { | |||
| bool _debugDoingSemantics = false; | |||
| final List<RenderObject> _nodesNeedingSemantics = <RenderObject>[]; | |||
|
|
|||
| /// Update the semantics for all render objects. | |||
| /// Update the semantics for render objects marked as needing a semantics | |||
| /// upadate. | |||
Hixie
reviewed
Jun 1, 2017
| @@ -2533,8 +2574,10 @@ abstract class RenderObject extends AbstractNode implements HitTestTarget { | |||
| if (annotator != null) | |||
| return new _ImplicitSemanticsFragment(renderObjectOwner: this, annotator: annotator, children: children); | |||
| _semantics = null; | |||
| if (children == null) | |||
| if (children == null) { | |||
| // Introduces no semantics and has no descendants that introduce semantic | |||
There was a problem hiding this comment.
add "s." to the end of this line
Hixie
reviewed
Jun 1, 2017
| @@ -2547,6 +2590,9 @@ abstract class RenderObject extends AbstractNode implements HitTestTarget { | |||
| /// | |||
| /// The default implementation mirrors the behavior of | |||
| /// [visitChildren()] (which is supposed to walk all the children). | |||
| /// | |||
| /// The implementation has to return the children in paint order skipping all | |||
| /// children that are not relevant for semantics. | |||
There was a problem hiding this comment.
These three paragraphs should be tweaked a bit, they're a bit repetitive right now.
|
|
goderbauer
added
the
a: accessibility
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.