Improved support for saving and restoring the scroll offset, etc V2 #10590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Jun 9, 2017
| @@ -611,6 +611,7 @@ class GalleryDrawer extends StatelessWidget { | |||
| final ScrollMode currentMode = ComplexLayoutApp.of(context).scrollMode; | |||
| return new Drawer( | |||
| child: new ListView( | |||
| key: const PageStorageKey<String>('gallery-drawer'), | |||
There was a problem hiding this comment.
The class is called GalleryDrawer and I'm tired.
|
|
This was referenced Jun 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reprise of #10517
The complex_layout benchmark was changed a little because PageStorage collisions in the version that was reverted were triggering ballistic scrolls that diminished benchmark performance.
There aren't any other substantive changes vis the original PR.