Factor out some common code in PaintingContext #10607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @abarth, who may care about this change. |
|
|
...and remove some highly specialised methods now that they can just be implemented directly by the previous callers.
Hixie
force-pushed
the
cleanPaintingContext
branch
from
66e2e4c
to
56e895f
Compare
|
Test failure was caused by the code invoking saveLayer() on the mock canvas (previously it was dropped on the floor because we didn't see inside the pushPhysicalModel call). Turns out we didn't track saveLayer() so the save count was off when we got to restore(). We now track saveLayer(). At some point we should make mock canvas much more aware of everything else going on here. |
|
will land on green unless @apwilson leaves the office first |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and remove some highly specialised methods now that they can just
be implemented directly by the previous callers.