Ensure Xcode major, minor version always return non-null #10980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, xcodeMajorVersion and xcodeMinorVersion returned null unless xcodeVersionSatisfactory had been called first. We now compute them on demand, and cache the resultant values.
tvolkert
reviewed
Jun 26, 2017
|
|
||
| final String version = match.group(1); | ||
| final List<String> components = version.split('.'); | ||
| _xcodeMajorVersion = int.parse(components[0]); |
There was a problem hiding this comment.
Looks like xcodeVersionSatisfactory needs an update too (it updates _xcodeMajorVersion and _xcodeMinorVersion)
There was a problem hiding this comment.
That's what I get for picking this up on a Monday after writing most of it on a Friday! Done.
tvolkert
reviewed
Jun 26, 2017
| _xcodeMajorVersion = int.parse(components[0]); | ||
| _xcodeMinorVersion = components.length == 1 ? 0 : int.parse(components[1]); | ||
| } on ProcessException { | ||
| // Ignore: return null below. |
There was a problem hiding this comment.
This isn't right any more.
There was a problem hiding this comment.
Good point - updated comment text.
tvolkert
approved these changes
Jun 26, 2017
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jul 1, 2017
Previously, xcodeMajorVersion and xcodeMinorVersion returned null unless xcodeVersionSatisfactory had been called first. We now compute them on demand, and cache the resultant values.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, xcodeMajorVersion and xcodeMinorVersion returned null unless
xcodeVersionSatisfactory had been called first. We now compute them on
demand, and cache the resultant values.