Added option to disable [NavigationDrawerDestination]s #132349

matheus-kirchesch · 2023-08-10T22:58:27Z

This PR adds a new option in the NavigationDrawerDestination api allowing it to be disabled, this is very useful for role based access control, especially in the navigation drawer which is used to lay out all the app destinations

Proposal to add option to Disable [NavigationDrawerDestination]s #132348

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

packages/flutter/lib/src/material/navigation_drawer.dart

matheus-kirchesch · 2023-08-31T17:41:03Z

bump

matheus-kirchesch · 2023-09-17T15:24:21Z

Bump 2

HansMuller

LGTM

QuncCccccc

Thanks a lot for the contribution! LGTM! Just left some nit:)

QuncCccccc · 2023-09-20T08:26:39Z

packages/flutter/lib/src/material/navigation_drawer.dart

@@ -229,12 +230,18 @@ class NavigationDrawerDestination extends StatelessWidget {
  /// text style would use [TextTheme.labelLarge] with [ColorScheme.onSurfaceVariant].
  final Widget label;

+  /// Indicates that this destination is selectable.


Suggested change

/// Indicates that this destination is selectable.

/// Indicates that this destination is selectable.

///

/// Defaults to true.

Seems this has a default value, so might be good to mention this:)

QuncCccccc · 2023-09-20T08:38:37Z

packages/flutter/lib/src/material/navigation_drawer.dart

@@ -322,20 +332,31 @@ class _NavigationDestinationBuilder extends StatelessWidget {
  /// animation is decreasing or dismissed.
  final WidgetBuilder buildLabel;

+  final bool enabled;


Should we also add some documentation here?

QuncCccccc · 2023-09-20T08:48:14Z

packages/flutter/test/material/navigation_drawer_test.dart

+          selectedIndex = i;
+        },
+      ),
+      useMaterial3: true,


Suggested change

useMaterial3: true,

We can just remove this because useMaterial3 defaults to true now:)

QuncCccccc · 2023-09-20T08:50:10Z

Seems Google testing is failed because of merge conflict. Could you help rebase master and solve the conflicts:) ?

matheus-kirchesch · 2023-09-20T14:06:30Z

Sure, will do it tonight

…ide it's test

…ment inserted during the development of the disable option in the NavigationDrawer

… double negatives

…tion

…to achieve the desired disabled color on the [NavigationDrawerDestination] widget

…rDestination] to its documentation. Also removed implicit useMaterial3 from its tests.

…tter/flutter#132349)

…tination widget) (#132361) This PR adds a new option in the NavigationDestination api (the destination widget for the NavigationBar) allowing it to be disabled. As the issue states this PR is the NavigationBar's version of these two PRs (#132349 and #127113) * #132359

…tter/flutter#132349)

This PR adds a new option in the NavigationDrawerDestination api allowing it to be disabled, this is very useful for role based access control, especially in the navigation drawer which is used to lay out all the app destinations * flutter#132348

…tination widget) (flutter#132361) This PR adds a new option in the NavigationDestination api (the destination widget for the NavigationBar) allowing it to be disabled. As the issue states this PR is the NavigationBar's version of these two PRs (flutter#132349 and flutter#127113) * flutter#132359

…tter/flutter#132349)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Aug 10, 2023

This was referenced Aug 10, 2023

Proposal to add option to Disable [NavigationDrawerDestination]s #132348

Closed

Added option to disable [NavigationDestination]s ([NavigationBar] destination widget) #132361

Merged

navaronbracke reviewed Aug 11, 2023

View reviewed changes

packages/flutter/lib/src/material/navigation_drawer.dart Outdated Show resolved Hide resolved

HansMuller self-requested a review August 11, 2023 21:46

HansMuller reviewed Aug 17, 2023

View reviewed changes

packages/flutter/lib/src/material/navigation_drawer.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/material/navigation_drawer.dart Outdated Show resolved Hide resolved

matheus-kirchesch requested a review from HansMuller September 19, 2023 12:41

HansMuller approved these changes Sep 19, 2023

View reviewed changes

QuncCccccc approved these changes Sep 20, 2023

View reviewed changes

matheus-kirchesch added 6 commits September 21, 2023 10:38

Added option to disable the NavigationDrawerDestination widget alongs…

3eec600

…ide it's test

Fixed the trailling spaces and lack of space after flow control state…

5a6487f

…ment inserted during the development of the disable option in the NavigationDrawer

Changed disabled property to enabled in the NavigationDrawer to avoid…

0890d65

… double negatives

Improved [NavigationDrawerDestination]'s [enabled] property documenta…

babbde2

…tion

Changed from using an Opacity widget to resolving the disabled state …

a4535df

…to achieve the desired disabled color on the [NavigationDrawerDestination] widget

Added the default state of [enabled] property in the [NavigationDrawe…

a8c43e7

…rDestination] to its documentation. Also removed implicit useMaterial3 from its tests.

HansMuller force-pushed the feature/disable_navigation_drawer_destinations branch from a6ce9ed to a8c43e7 Compare September 21, 2023 17:38

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 22, 2023

auto-submit bot merged commit 801a1c9 into flutter:master Sep 22, 2023
67 checks passed

engine-flutter-autoroll mentioned this pull request Sep 22, 2023

Roll Flutter from 893650416352 to f58163447f3b (86 revisions) flutter/packages#4978

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023

801a1c930 Added option to disable [NavigationDrawerDestination]s (flu…

a04b451

…tter/flutter#132349)

engine-flutter-autoroll mentioned this pull request Sep 22, 2023

Roll Flutter from 893650416352 to 06780cb1d069 (87 revisions) flutter/packages#4979

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023

801a1c930 Added option to disable [NavigationDrawerDestination]s (flu…

b558b53

…tter/flutter#132349)

engine-flutter-autoroll mentioned this pull request Sep 22, 2023

Roll Flutter from 893650416352 to 74c6693170e1 (88 revisions) flutter/packages#4980

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023

801a1c930 Added option to disable [NavigationDrawerDestination]s (flu…

894c06c

…tter/flutter#132349)

engine-flutter-autoroll mentioned this pull request Sep 22, 2023

Roll Flutter from 893650416352 to dbe0ccd8853d (89 revisions) flutter/packages#4981

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023

801a1c930 Added option to disable [NavigationDrawerDestination]s (flu…

793219f

…tter/flutter#132349)

engine-flutter-autoroll mentioned this pull request Sep 22, 2023

Roll Flutter from 893650416352 to 76a938bfa6d1 (90 revisions) flutter/packages#4983

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023

801a1c930 Added option to disable [NavigationDrawerDestination]s (flu…

c9e3ab7

…tter/flutter#132349)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2023

801a1c930 Added option to disable [NavigationDrawerDestination]s (flu…

f5185a9

…tter/flutter#132349)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023

801a1c930 Added option to disable [NavigationDrawerDestination]s (flu…

3de7213

…tter/flutter#132349)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023

801a1c930 Added option to disable [NavigationDrawerDestination]s (flu…

cc7af22

…tter/flutter#132349)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023

801a1c930 Added option to disable [NavigationDrawerDestination]s (flu…

a52b449

…tter/flutter#132349)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023

801a1c930 Added option to disable [NavigationDrawerDestination]s (flu…

ffd92c8

…tter/flutter#132349)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023

801a1c930 Added option to disable [NavigationDrawerDestination]s (flu…

3ac60d8

…tter/flutter#132349)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023

801a1c930 Added option to disable [NavigationDrawerDestination]s (flu…

689ad9d

…tter/flutter#132349)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023

801a1c930 Added option to disable [NavigationDrawerDestination]s (flu…

89981b5

…tter/flutter#132349)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023

801a1c930 Added option to disable [NavigationDrawerDestination]s (flu…

214eb71

…tter/flutter#132349)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023

801a1c930 Added option to disable [NavigationDrawerDestination]s (flu…

07d159a

…tter/flutter#132349)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023

801a1c930 Added option to disable [NavigationDrawerDestination]s (flu…

07669d1

…tter/flutter#132349)

HansMuller mentioned this pull request Sep 28, 2023

Flutter Framework Team: Notable Commits #121415

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023

801a1c930 Added option to disable [NavigationDrawerDestination]s (flu…

2ae319a

…tter/flutter#132349)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023

801a1c930 Added option to disable [NavigationDrawerDestination]s (flu…

e8047ef

…tter/flutter#132349)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023

801a1c930 Added option to disable [NavigationDrawerDestination]s (flu…

a8ff0b4

…tter/flutter#132349)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023

801a1c930 Added option to disable [NavigationDrawerDestination]s (flu…

2dd4eec

…tter/flutter#132349)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023

801a1c930 Added option to disable [NavigationDrawerDestination]s (flu…

1a82663

…tter/flutter#132349)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023

801a1c930 Added option to disable [NavigationDrawerDestination]s (flu…

4b532d5

…tter/flutter#132349)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023

801a1c930 Added option to disable [NavigationDrawerDestination]s (flu…

10ba804

…tter/flutter#132349)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added option to disable [NavigationDrawerDestination]s #132349

Added option to disable [NavigationDrawerDestination]s #132349

matheus-kirchesch commented Aug 10, 2023

matheus-kirchesch commented Aug 31, 2023

matheus-kirchesch commented Sep 17, 2023

HansMuller left a comment

QuncCccccc left a comment

QuncCccccc Sep 20, 2023

QuncCccccc Sep 20, 2023

QuncCccccc Sep 20, 2023

QuncCccccc Sep 20, 2023

QuncCccccc commented Sep 20, 2023

matheus-kirchesch commented Sep 20, 2023

Added option to disable [NavigationDrawerDestination]s #132349

Added option to disable [NavigationDrawerDestination]s #132349

Conversation

matheus-kirchesch commented Aug 10, 2023

Pre-launch Checklist

matheus-kirchesch commented Aug 31, 2023

matheus-kirchesch commented Sep 17, 2023

HansMuller left a comment

Choose a reason for hiding this comment

QuncCccccc left a comment

Choose a reason for hiding this comment

QuncCccccc Sep 20, 2023

Choose a reason for hiding this comment

QuncCccccc Sep 20, 2023

Choose a reason for hiding this comment

QuncCccccc Sep 20, 2023

Choose a reason for hiding this comment

QuncCccccc Sep 20, 2023

Choose a reason for hiding this comment

QuncCccccc commented Sep 20, 2023

matheus-kirchesch commented Sep 20, 2023