Cover some test/widgets tests with leak tracking #133803

ksokolovskyi · 2023-08-31T20:39:07Z

Description

This is the fixed copy of the #133767.

This PR changes testWidgets by testWidgetsWithLeakTracking in number of flutter/test/widgets tests according to the dart-lang/leak_tracker#134.

Marks leaks

Memory Leak: _RouterState doesn't dispose _RestorableRouteInformation #134205

Tests

Updates absorb_pointer_test.dart to use testWidgetsWithLeakTracking;
Updates actions_test.dart to use testWidgetsWithLeakTracking;
Updates align_test.dart to use testWidgetsWithLeakTracking;
Updates animated_align_test.dart to use testWidgetsWithLeakTracking;
Updates animated_container_test.dart to use testWidgetsWithLeakTracking;
Updates animated_cross_fade_test.dart to use testWidgetsWithLeakTracking;
Updates animated_grid_test.dart to use testWidgetsWithLeakTracking;
Updates animated_image_filtered_repaint_test.dart to use testWidgetsWithLeakTracking;
Updates animated_list_test.dart to use testWidgetsWithLeakTracking;
Updates animated_opacity_repaint_test.dart to use testWidgetsWithLeakTracking;
Updates animated_padding_test.dart to use testWidgetsWithLeakTracking;
Updates animated_positioned_test.dart to use testWidgetsWithLeakTracking;
Updates animated_size_test.dart to use testWidgetsWithLeakTracking;
Updates animated_switcher_test.dart to use testWidgetsWithLeakTracking;
Updates annotated_region_test.dart to use testWidgetsWithLeakTracking;
Updates app_lifecycle_listener_test.dart to use testWidgetsWithLeakTracking;
Updates app_navigator_key_test.dart to use testWidgetsWithLeakTracking;
Updates app_overrides_test.dart to use testWidgetsWithLeakTracking;
Updates app_test.dart to use testWidgetsWithLeakTracking;
Updates app_title_test.dart to use testWidgetsWithLeakTracking;
Updates aspect_ratio_test.dart to use testWidgetsWithLeakTracking;
Updates async_test.dart to use testWidgetsWithLeakTracking;
Updates autocomplete_test.dart to use testWidgetsWithLeakTracking;
Updates autofill_group_test.dart to use testWidgetsWithLeakTracking;
Updates automatic_keep_alive_test.dart to use testWidgetsWithLeakTracking;
Updates backdrop_filter_test.dart to use testWidgetsWithLeakTracking;
Updates banner_test.dart to use testWidgetsWithLeakTracking;
Updates baseline_test.dart to use testWidgetsWithLeakTracking;
Updates basic_test.dart to use testWidgetsWithLeakTracking;
Updates binding_deferred_first_frame_test.dart to use testWidgetsWithLeakTracking;
Updates binding_test.dart to use testWidgetsWithLeakTracking;
Updates box_decoration_test.dart to use testWidgetsWithLeakTracking;
Updates build_context_test.dart to use testWidgetsWithLeakTracking;
Updates build_scope_test.dart to use testWidgetsWithLeakTracking;
Updates center_test.dart to use testWidgetsWithLeakTracking;
Updates clamp_overscrolls_test.dart to use testWidgetsWithLeakTracking;
Updates clip_test.dart to use testWidgetsWithLeakTracking;
Updates color_filter_test.dart to use testWidgetsWithLeakTracking;
Updates column_test.dart to use testWidgetsWithLeakTracking;
Updates composited_transform_test.dart to use testWidgetsWithLeakTracking;
Updates constrained_box_test.dart to use testWidgetsWithLeakTracking;
Updates container_test.dart to use testWidgetsWithLeakTracking;
Updates context_menu_controller_test.dart to use testWidgetsWithLeakTracking;
Updates coordinates_test.dart to use testWidgetsWithLeakTracking;
Updates custom_multi_child_layout_test.dart to use testWidgetsWithLeakTracking;
Updates custom_paint_test.dart to use testWidgetsWithLeakTracking;
Updates custom_painter_test.dart to use testWidgetsWithLeakTracking;
Updates custom_scroll_view_test.dart to use testWidgetsWithLeakTracking;
Updates custom_single_child_layout_test.dart to use testWidgetsWithLeakTracking;
Updates debug_test.dart to use testWidgetsWithLeakTracking;
Updates decorated_sliver_test.dart to use testWidgetsWithLeakTracking;
Updates default_colors_test.dart to use testWidgetsWithLeakTracking;
Updates default_text_editing_shortcuts_test.dart to use testWidgetsWithLeakTracking;
Updates default_text_height_behavior_test.dart to use testWidgetsWithLeakTracking;
Updates default_text_style_test.dart to use testWidgetsWithLeakTracking;
Updates did_update_widget_test.dart to use testWidgetsWithLeakTracking;
Updates directionality_test.dart to use testWidgetsWithLeakTracking;
Updates dismissible_test.dart to use testWidgetsWithLeakTracking;
Updates display_feature_sub_screen_test.dart to use testWidgetsWithLeakTracking;
Updates disposable_build_context_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

ksokolovskyi · 2023-08-31T21:00:17Z

@polina-c please review this PR when you have time.

polina-c · 2023-08-31T21:55:08Z

packages/flutter/test/widgets/actions_test.dart

@@ -392,9 +393,11 @@ void main() {
      await buildTest(true);
      expect(hovering, isFalse);
      expect(focusing, isFalse);
+
+      focusNode.dispose();


Can you update disposals to be aligned with newly gained knowledge: dart-lang/leak_tracker#138

@polina-c great rule, thanks.

polina-c

One small comment.

ksokolovskyi · 2023-09-02T10:25:51Z

@polina-c Could you please take a look again?

ksokolovskyi · 2023-09-07T12:21:19Z

@polina-c could you please take a look again?

…lutter#133803)

…4870) Manual roll Flutter from 685ce14b2d0f to aea4552acdc7 (64 revisions) Manual roll requested by dit@google.com flutter/flutter@685ce14...aea4552 2023-09-07 andrewrkolos@gmail.com add --exit flag to dev/devicelab/bin/test_runner.dart (flutter/flutter#134165) 2023-09-07 andrewrkolos@gmail.com fix `--exit` flag in dev/devicelab/bin/run.dart (flutter/flutter#134162) 2023-09-07 engine-flutter-autoroll@skia.org Roll Packages from e7d812c to 22d4754 (9 revisions) (flutter/flutter#134232) 2023-09-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 71bea01d3abe to f0b718e28779 (2 revisions) (flutter/flutter#134231) 2023-09-07 polinach@google.com DropdownRoutePage should dispose the created ScrollController. (flutter/flutter#133941) 2023-09-07 sokolovskyi.konstantin@gmail.com Cover some test/widgets tests with leak tracking (flutter/flutter#133803) 2023-09-07 polinach@google.com SearchDelegate should dispose resources. (flutter/flutter#133948) 2023-09-07 matheus@btor.com.br Fixed [NavigationRailDestination]'s label opacity while disabled not being coherent with the icon (flutter/flutter#132345) 2023-09-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 558136a1ccbf to 71bea01d3abe (2 revisions) (flutter/flutter#134216) 2023-09-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5a45ecd24aa3 to 558136a1ccbf (1 revision) (flutter/flutter#134206) 2023-09-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from d864ae68db3c to 5a45ecd24aa3 (1 revision) (flutter/flutter#134201) 2023-09-07 tessertaha@gmail.com Fix `TabBar` doesn't use `labelStyle` & `unselectedLabelStyle` color (flutter/flutter#133989) 2023-09-07 tessertaha@gmail.com Fix `DataTable`'s `headingTextStyle` & `dataTextStyle` are not merged with default text style (flutter/flutter#134138) 2023-09-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 187c5b3c5f71 to d864ae68db3c (2 revisions) (flutter/flutter#134199) 2023-09-07 tessertaha@gmail.com Reland "Fix `Chip.shape`'s side is not used when provided in Material 3" (flutter/flutter#133856) 2023-09-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 75437a3bd002 to 187c5b3c5f71 (1 revision) (flutter/flutter#134193) 2023-09-07 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 2c69d05dfafb to 75437a3bd002 (15 revisions) (flutter/flutter#134188) 2023-09-07 zanderso@users.noreply.github.com Revert "Roll Flutter Engine from 2c69d05dfafb to fa14d337449b (6 revisions)" (flutter/flutter#134183) 2023-09-06 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.2 to 3.1.3 (flutter/flutter#134173) 2023-09-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2c69d05dfafb to fa14d337449b (6 revisions) (flutter/flutter#134169) 2023-09-06 polinach@google.com DraggableScrollableActuator should dispose notifier. (flutter/flutter#133917) 2023-09-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from b04c2a378302 to 2c69d05dfafb (3 revisions) (flutter/flutter#134164) 2023-09-06 polinach@google.com Clean the fixed TODOs. (flutter/flutter#133859) 2023-09-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 839051596b1d to b04c2a378302 (7 revisions) (flutter/flutter#134158) 2023-09-06 737941+loic-sharma@users.noreply.github.com [Windows Arm64] Also use Windows 11 for Devicelab tests (flutter/flutter#134082) 2023-09-06 70351342+burakJs@users.noreply.github.com Fix `subtitleTextStyle.color` isn't applied to the `ListTile.subtitle` in Material 2 (flutter/flutter#133422) 2023-09-06 pateltirth454@gmail.com Add `CheckedPopupMenuItem.onTap` callback (flutter/flutter#134000) 2023-09-06 polinach@google.com MinimumTextContrastGuideline should dispose image. (flutter/flutter#133861) 2023-09-06 christopherfujino@gmail.com [flutter_tools] Fix "FormatException: Invalid date format" during version freshness check (flutter/flutter#134088) 2023-09-06 polinach@google.com Fix not disposed items in Cupertino app and route. (flutter/flutter#134085) 2023-09-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from a5e7fa6bf81a to 839051596b1d (2 revisions) (flutter/flutter#134140) 2023-09-06 polinach@google.com _DropdownMenuState should dispose TextEditingController. (flutter/flutter#133914) 2023-09-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5253a33096d1 to a5e7fa6bf81a (1 revision) (flutter/flutter#134137) 2023-09-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from c7fd088291e2 to 5253a33096d1 (1 revision) (flutter/flutter#134135) 2023-09-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3d9989f1e155 to c7fd088291e2 (1 revision) (flutter/flutter#134132) 2023-09-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from bace539bb654 to 3d9989f1e155 (3 revisions) (flutter/flutter#134128) 2023-09-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9344685efbc3 to bace539bb654 (1 revision) (flutter/flutter#134104) 2023-09-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0c8c1647dcd0 to 9344685efbc3 (1 revision) (flutter/flutter#134103) 2023-09-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0c663258fd09 to 0c8c1647dcd0 (1 revision) (flutter/flutter#134100) 2023-09-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8bacc3b38707 to 0c663258fd09 (3 revisions) (flutter/flutter#134096) 2023-09-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 590349006d23 to 8bacc3b38707 (5 revisions) (flutter/flutter#134089) 2023-09-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5b2cc9d9b8fe to 590349006d23 (2 revisions) (flutter/flutter#134081) 2023-09-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 98b036ae708e to 5b2cc9d9b8fe (2 revisions) (flutter/flutter#134080) 2023-09-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from f4975e04f35e to 98b036ae708e (3 revisions) (flutter/flutter#134077) ...

…lutter#133803)

ksokolovskyi added 3 commits August 31, 2023 17:12

Test cover some test/widgets tests with leak tracking

e60fcec

Merge branch 'master' into leak-tracking-tests

412ee65

Fix animated_list_test.dart

d70c03d

github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 31, 2023

polina-c reviewed Aug 31, 2023

View reviewed changes

polina-c requested changes Aug 31, 2023

View reviewed changes

ksokolovskyi added 2 commits September 2, 2023 11:32

Move dispose to the tearDown

192fcd1

Merge branch 'master' into leak-tracking-tests

ecf91a8

polina-c approved these changes Sep 2, 2023

View reviewed changes

polina-c mentioned this pull request Sep 2, 2023

Clean up notDisposed leaks in Flutter Framework, phase 1. dart-lang/leak_tracker#134

Closed

ksokolovskyi added 2 commits September 6, 2023 13:27

Merge branch 'master' into leak-tracking-tests

46a6c95

Add more tests

5f6aa53

github-actions bot added a: text input Entering text in a text field or keyboard related problems f: scrolling Viewports, list views, slivers, etc. f: routes Navigator, Router, and related APIs. labels Sep 6, 2023

ksokolovskyi requested a review from polina-c September 6, 2023 15:24

ksokolovskyi added 2 commits September 6, 2023 17:26

Merge branch 'master' into leak-tracking-tests

0bdfbee

Merge branch 'master' into leak-tracking-tests

b06d4d0

ksokolovskyi mentioned this pull request Sep 7, 2023

Memory Leak: _RouterState doesn't dispose _RestorableRouteInformation #134205

Closed

2 tasks

ksokolovskyi added 2 commits September 7, 2023 12:22

Revert _routeInformation disposal, Marked leak in router.dart

033f7c9

Add more tests

1c2bc4c

polina-c merged commit aca91df into flutter:master Sep 7, 2023
67 checks passed

engine-flutter-autoroll mentioned this pull request Sep 7, 2023

Roll Flutter from c175cf87a6a3 to aca91df6b784 (115 revisions) flutter/packages#4868

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023

aca91df6b Cover some test/widgets tests with leak tracking (flutter/f…

63a73bf

…lutter#133803)

engine-flutter-autoroll mentioned this pull request Sep 7, 2023

Roll Flutter from c175cf87a6a3 to ea351694fe5b (118 revisions) flutter/packages#4869

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023

aca91df6b Cover some test/widgets tests with leak tracking (flutter/f…

bb6de27

…lutter#133803)

engine-flutter-autoroll mentioned this pull request Sep 7, 2023

Manual roll Flutter from 685ce14b2d0f to aea4552acdc7 (64 revisions) flutter/packages#4870

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023

aca91df6b Cover some test/widgets tests with leak tracking (flutter/f…

cb9690d

…lutter#133803)

HansMuller mentioned this pull request Sep 8, 2023

Flutter Framework Team: Notable Commits #121415

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023

aca91df6b Cover some test/widgets tests with leak tracking (flutter/f…

f4007b6

…lutter#133803)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cover some test/widgets tests with leak tracking #133803

Cover some test/widgets tests with leak tracking #133803

ksokolovskyi commented Aug 31, 2023 •

edited

ksokolovskyi commented Aug 31, 2023

polina-c Aug 31, 2023

ksokolovskyi Sep 2, 2023

polina-c left a comment

ksokolovskyi commented Sep 2, 2023

ksokolovskyi commented Sep 7, 2023

Cover some test/widgets tests with leak tracking #133803

Cover some test/widgets tests with leak tracking #133803

Conversation

ksokolovskyi commented Aug 31, 2023 • edited

Description

Marks leaks

Tests

Pre-launch Checklist

ksokolovskyi commented Aug 31, 2023

polina-c Aug 31, 2023

Choose a reason for hiding this comment

ksokolovskyi Sep 2, 2023

Choose a reason for hiding this comment

polina-c left a comment

Choose a reason for hiding this comment

ksokolovskyi commented Sep 2, 2023

ksokolovskyi commented Sep 7, 2023

ksokolovskyi commented Aug 31, 2023 •

edited