Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputDecoration.error should activate error state #134001

Merged
merged 3 commits into from
Sep 8, 2023
Merged

InputDecoration.error should activate error state #134001

merged 3 commits into from
Sep 8, 2023

Conversation

Renzo-Olivares
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares commented Sep 4, 2023 •
edited

When passed an error widget, InputDecoration should activate its error state. Before this change the errorBorder would only activate if an errorText was provided. This change solves this issue by accounting for a provided error widget.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Sep 4, 2023
@Renzo-Olivares Renzo-Olivares marked this pull request as ready for review September 4, 2023 22:00
bleroux
bleroux reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@bleroux bleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

packages/flutter/test/material/input_decorator_test.dart Outdated
),
),
);
await tester.pumpAndSettle(); // border changes are animated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider starting this recurring comment in uppercase and adding a period.

@Renzo-Olivares Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 6, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 6, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 6, 2023

auto label is removed for flutter/flutter/134001, due to - The status or check suite Linux web_tests_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Linux web_tests_1 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Renzo-Olivares Renzo-Olivares added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Sep 6, 2023
@auto-submit auto-submit bot merged commit 97cdc0e into flutter:master Sep 8, 2023
66 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 9, 2023
@engine-flutter-autoroll
97cdc0ec0 InputDecoration.error should activate error state (flutter/…
e8a2484 
…flutter#134001)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 9, 2023
@engine-flutter-autoroll
97cdc0ec0 InputDecoration.error should activate error state (flutter/…
a767b6c 
…flutter#134001)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 9, 2023
@engine-flutter-autoroll
97cdc0ec0 InputDecoration.error should activate error state (flutter/…
734c9ad 
…flutter#134001)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 9, 2023
@engine-flutter-autoroll
97cdc0ec0 InputDecoration.error should activate error state (flutter/…
f5d9ef6 
…flutter#134001)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 9, 2023
@engine-flutter-autoroll
Roll Flutter from da676f79aa37 to 7c28e8eb0734 (20 revisions) (#4879)
e656e79 
flutter/flutter@da676f7...7c28e8e

2023-09-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4e3231af6efc to d1913cb6a276 (1 revision) (flutter/flutter#134355)
2023-09-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 348e3a376807 to 4e3231af6efc (1 revision) (flutter/flutter#134353)
2023-09-09 polinach@google.com Day picker should dispose created MaterialStatesController's. (flutter/flutter#133884)
2023-09-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 00ef109b845e to 348e3a376807 (1 revision) (flutter/flutter#134349)
2023-09-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7af8a5d8d556 to 00ef109b845e (1 revision) (flutter/flutter#134336)
2023-09-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1f2da3d69da7 to 7af8a5d8d556 (2 revisions) (flutter/flutter#134332)
2023-09-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3a5f3ad1d054 to 1f2da3d69da7 (1 revision) (flutter/flutter#134328)
2023-09-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from d6aa2d9061c1 to 3a5f3ad1d054 (3 revisions) (flutter/flutter#134327)
2023-09-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 66bec85d5005 to d6aa2d9061c1 (1 revision) (flutter/flutter#134324)
2023-09-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8d2892211366 to 66bec85d5005 (3 revisions) (flutter/flutter#134321)
2023-09-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2da727e23518 to 8d2892211366 (1 revision) (flutter/flutter#134316)
2023-09-08 sokolovskyi.konstantin@gmail.com Fix memory leak in _DraggableScrollableSheetState (flutter/flutter#134212)
2023-09-08 polinach@google.com RestorationManager should dispatch creation in constructor. (flutter/flutter#133911)
2023-09-08 31859944+LongCatIsLooong@users.noreply.github.com Remove TextPainter migration flag from the framework (flutter/flutter#134274)
2023-09-08 rmolivares@renzo-olivares.dev InputDecoration.error should activate error state (flutter/flutter#134001)
2023-09-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from b2cb1d271a88 to 2da727e23518 (1 revision) (flutter/flutter#134314)
2023-09-08 tessertaha@gmail.com Update chip docs to clarify how to specify a shape with no border & explain default values for Material 3 (flutter/flutter#134298)
2023-09-08 47866232+chunhtai@users.noreply.github.com Add ios analyzer command for universal links (flutter/flutter#134155)
2023-09-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 47a79306eed3 to b2cb1d271a88 (5 revisions) (flutter/flutter#134313)
2023-09-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6d6b44886175 to 47a79306eed3 (2 revisions) (flutter/flutter#134310)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@slaci
Copy link

slaci commented Sep 22, 2023 •
edited

Hello, why isn't this tagged as a bug? 🤔 Without this the error property of the InputDecoration (released in 3.13) is totally useless. It is basically a helperText widget without this fix.
Edit: I mean now its 3 more months until the (already released) error property can be used for anything for those who stick to the stable, until that its just there.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
97cdc0ec0 InputDecoration.error should activate error state (flutter/…
eed9474 
…flutter#134001)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bleroux bleroux bleroux approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Renzo-Olivares @slaci @bleroux