Make `CupertinoTextField` at least as tall as its first line of placeholder #134198

LongCatIsLooong · 2023-09-07T06:59:43Z

Fixes #133241
and some CupertinoTextField cleanup.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…lder

Renzo-Olivares · 2023-09-07T20:02:49Z

packages/flutter/lib/src/cupertino/text_field.dart

-      attachment: widget.clearButtonMode,
-      hasText: text.text.isNotEmpty,
-    );
+    return switch (attachment) {


TIL you can use switch statements in this way. Awesome!

This is new in dart3. It's a switch expression (an expression evaluates to a value so you can directly return a switch expression), a bit different from a switch statement.

Renzo-Olivares · 2023-09-07T20:24:40Z

packages/flutter/lib/src/cupertino/text_field.dart

@@ -1134,6 +1111,31 @@ class _CupertinoTextFieldState extends State<CupertinoTextField> with Restoratio
    return _hasDecoration ? TextAlignVertical.center : TextAlignVertical.top;
  }

+  void _onClearButtonTapped() {
+    // Special handle onChanged for ClearButton


consider consolidating this comment into one sentence. maybe something like Handler for ClearButton that calls onChanged when the clear button is tapped.

I basically moved the code and the comment to an instance method. I'll update the comment.

Renzo-Olivares · 2023-09-07T20:27:50Z

packages/flutter/lib/src/cupertino/text_field.dart

@@ -393,7 +393,7 @@ class CupertinoTextField extends StatefulWidget {
    this.onSubmitted,
    this.onTapOutside,
    this.inputFormatters,
-    this.enabled,
+    this.enabled = true,


I wonder if we should just make this a private variable inside of CupertinoTextFieldState similar to how TextFieldState does it. I'm not too opinionated on this either way but it would keep the API consistent between both TextFields.

TextField.enabled? is a bool? because it can default to InputDecoration.enabled I think. Here it doesn't have anything to default to other than the const true so I don't know if there's a good reason to keep this bool?.

I don't think we need to store enabled in CupertinoTextFieldState since the configuration is completely determined by the widget itself (CupertinoTextField.enabled), unless I'm missing something?

I didn't consider the defaults in InputDecoration, that makes sense to me then.

Renzo-Olivares · 2023-09-07T20:34:16Z

packages/flutter/lib/src/cupertino/text_field.dart

+              // Ideally this should be baseline aligned. However that comes at
+              // the cost of the ability to compute the intrinsic dimensions of
+              // this widget.
+              // See also https://github.com/flutter/flutter/issues/13715


nit: consider adding a period at the end of this line.

Renzo-Olivares · 2023-09-07T20:43:45Z

packages/flutter/lib/src/cupertino/text_field.dart

+        final String? placeholderText = widget.placeholder;
+        final Widget? placeholder = placeholderText == null
+          ? null
+          : Visibility(


Before this change the placeholder would not be built at all if there was text, but now it is built regardless but hidden when there is text. This is so the input field does not shrink when the user starts entering text because now the placeholder is still there just hidden.

Just wondering if I am understanding this change correctly.

Yeah the placeholder will be kept in the widget tree to make sure the text field's height is always greater than or equal to the height of the first line of the placeholder, even when there's user text.

…ng/flutter into taller-cupertino-textfield

…textfield

Renzo-Olivares

LGTM

MitchellGoodwin

LGTM

…e of placeholder (flutter/flutter#134198)

flutter/flutter@aea4552...da676f7 2023-09-08 fluttergithubbot@gmail.com Marks Linux_android very_long_picture_scrolling_perf__e2e_summary to be unflaky (flutter/flutter#134116) 2023-09-08 31859944+LongCatIsLooong@users.noreply.github.com Make `CupertinoTextField` at least as tall as its first line of placeholder (flutter/flutter#134198) 2023-09-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from f09a139101c3 to 6d6b44886175 (3 revisions) (flutter/flutter#134306) 2023-09-08 gspencergoog@users.noreply.github.com Update links to iOS embedder docs to point to new Doxygen docs (flutter/flutter#134246) 2023-09-08 engine-flutter-autoroll@skia.org Roll Packages from 22d4754 to aaae5ef (7 revisions) (flutter/flutter#134301) 2023-09-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from c38feb382e96 to f09a139101c3 (1 revision) (flutter/flutter#134299) 2023-09-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from f146d4bf244b to c38feb382e96 (1 revision) (flutter/flutter#134293) 2023-09-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from a140ab4a4ec6 to f146d4bf244b (1 revision) (flutter/flutter#134290) 2023-09-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from ea1d0d28e26f to a140ab4a4ec6 (5 revisions) (flutter/flutter#134288) 2023-09-08 xubaolin@oppo.com fix a Scrollbar example crash (flutter/flutter#127925) 2023-09-08 tessertaha@gmail.com Fix `Drawer` examples are missing `dartpad` tag (flutter/flutter#134219) 2023-09-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4ac4429a206b to ea1d0d28e26f (1 revision) (flutter/flutter#134270) 2023-09-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from df3965a55fd8 to 4ac4429a206b (1 revision) (flutter/flutter#134267) 2023-09-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 505ef3c33102 to df3965a55fd8 (1 revision) (flutter/flutter#134263) 2023-09-08 polinach@google.com _TabBarViewState should dispose created instances of PageController. (flutter/flutter#134091) 2023-09-08 polinach@google.com Remove non needed controllers in SegmentedButton. (flutter/flutter#134064) 2023-09-08 polinach@google.com EditableTextState should dispose cursorVisibilityNotifier. (flutter/flutter#133858) 2023-09-08 polinach@google.com TestWidgetsFlutterBinding should dispose old RestorationManager on reset. (flutter/flutter#133999) 2023-09-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 65f6fb841c7a to 505ef3c33102 (4 revisions) (flutter/flutter#134260) 2023-09-07 polinach@google.com CupertinoAlertDialog should not create ScrollController on every build, if null values are passed in constructor. (flutter/flutter#134075) 2023-09-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from a828c26e7e97 to 65f6fb841c7a (1 revision) (flutter/flutter#134254) 2023-09-07 polinach@google.com _SearchBarState should dispose FocusNode, if it created it. (flutter/flutter#134076) 2023-09-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2dba8ceca824 to a828c26e7e97 (8 revisions) (flutter/flutter#134249) 2023-09-07 34871572+gmackall@users.noreply.github.com [integration_test] Allow capture of screenshots for `FlutterFragmentActivity`s (flutter/flutter#132406) 2023-09-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8d07c2947e60 to 2dba8ceca824 (2 revisions) (flutter/flutter#134243) 2023-09-07 tessertaha@gmail.com Fix `ExpansionTile` properties cannot be updated with `setState` (flutter/flutter#134218) 2023-09-07 737941+loic-sharma@users.noreply.github.com [Windows Arm64] Remove device_type property (flutter/flutter#134181) 2023-09-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from f0b718e28779 to 8d07c2947e60 (3 revisions) (flutter/flutter#134240) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

moffatman · 2023-10-29T22:14:45Z

packages/flutter/lib/src/cupertino/text_field.dart

          // In the middle part, stack the placeholder on top of the main EditableText
          // if needed.
          Expanded(
            child: Stack(
+              // Ideally this should be baseline aligned. However that comes at


Since this change, the placeholder is vertically centered on multi-line textfield instead of being on the first line, because alignment is set to center instead of default topLeft. Is this intended? Not sure how to read the comment above.

Yeah it should be baseline aligned with the input text instead of center aligned. I'll try to fix that.

…e of placeholder (flutter/flutter#134198)

Make CupertinoTextField at least as tall as its first line of placeho…

d067c3d

…lder

github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Sep 7, 2023

LongCatIsLooong marked this pull request as ready for review September 7, 2023 18:03

LongCatIsLooong requested review from Renzo-Olivares and MitchellGoodwin September 7, 2023 18:03

Update text_field.dart

db75357

Renzo-Olivares reviewed Sep 7, 2023

View reviewed changes

LongCatIsLooong added 3 commits September 7, 2023 22:51

review

eb1f6b4

Merge branch 'taller-cupertino-textfield' of github.com:LongCatIsLooo…

a85152f

…ng/flutter into taller-cupertino-textfield

Merge remote-tracking branch 'upstream/master' into taller-cupertino-…

3521500

…textfield

Renzo-Olivares approved these changes Sep 8, 2023

View reviewed changes

MitchellGoodwin approved these changes Sep 8, 2023

View reviewed changes

LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 8, 2023

auto-submit bot merged commit 804a7b2 into flutter:master Sep 8, 2023
67 checks passed

LongCatIsLooong deleted the taller-cupertino-textfield branch September 8, 2023 16:54

engine-flutter-autoroll mentioned this pull request Sep 8, 2023

Roll Flutter from aea4552acdc7 to da676f79aa37 (28 revisions) flutter/packages#4874

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2023

804a7b285 Make CupertinoTextField at least as tall as its first lin…

6ad94d4

…e of placeholder (flutter/flutter#134198)

HansMuller mentioned this pull request Sep 8, 2023

Flutter Framework Team: Notable Commits #121415

Open

moffatman reviewed Oct 29, 2023

View reviewed changes

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023

804a7b285 Make CupertinoTextField at least as tall as its first lin…

1af09f7

…e of placeholder (flutter/flutter#134198)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make `CupertinoTextField` at least as tall as its first line of placeholder #134198

Make `CupertinoTextField` at least as tall as its first line of placeholder #134198

LongCatIsLooong commented Sep 7, 2023

Renzo-Olivares Sep 7, 2023

LongCatIsLooong Sep 8, 2023

Renzo-Olivares Sep 7, 2023

LongCatIsLooong Sep 8, 2023

Renzo-Olivares Sep 7, 2023

LongCatIsLooong Sep 8, 2023

Renzo-Olivares Sep 8, 2023

Renzo-Olivares Sep 7, 2023

Renzo-Olivares Sep 7, 2023

Renzo-Olivares Sep 7, 2023

LongCatIsLooong Sep 8, 2023

Renzo-Olivares left a comment

MitchellGoodwin left a comment

moffatman Oct 29, 2023

LongCatIsLooong Oct 31, 2023

Make CupertinoTextField at least as tall as its first line of placeholder #134198

Make CupertinoTextField at least as tall as its first line of placeholder #134198

Conversation

LongCatIsLooong commented Sep 7, 2023

Pre-launch Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Renzo-Olivares left a comment

Choose a reason for hiding this comment

MitchellGoodwin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Make `CupertinoTextField` at least as tall as its first line of placeholder #134198

Make `CupertinoTextField` at least as tall as its first line of placeholder #134198