Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover more tests with leak tracking. #134363

Merged
merged 7 commits into from
Sep 11, 2023
Merged

Cover more tests with leak tracking. #134363

merged 7 commits into from
Sep 11, 2023

Conversation

polina-c
Copy link
Contributor

No description provided.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Sep 10, 2023
@polina-c polina-c changed the title Success Cover more tests with leak tracking. Sep 10, 2023
@polina-c polina-c marked this pull request as ready for review September 10, 2023 18:53
@polina-c polina-c mentioned this pull request Sep 11, 2023
Closed
chunhtai
chunhtai approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polina-c polina-c merged commit 219efce into flutter:master Sep 11, 2023
66 of 67 checks passed
@polina-c polina-c deleted the success branch September 11, 2023 16:42
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 11, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2023
@engine-flutter-autoroll
219efce7f Cover more tests with leak tracking. (flutter/flutter#134363)
8781afa
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 11, 2023
@engine-flutter-autoroll
Roll Flutter from 7c28e8eb0734 to 219efce7f16d (16 revisions) (#4901)
ef0c65e 
flutter/flutter@7c28e8e...219efce

2023-09-11 polinach@google.com Cover more tests with leak tracking. (flutter/flutter#134363)
2023-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from e9f1696e5060 to 2b5961cbc40d (1 revision) (flutter/flutter#134424)
2023-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from ac6be4dbf821 to e9f1696e5060 (1 revision) (flutter/flutter#134410)
2023-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1aa11b644855 to ac6be4dbf821 (1 revision) (flutter/flutter#134407)
2023-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7e41b064eb23 to 1aa11b644855 (2 revisions) (flutter/flutter#134404)
2023-09-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 04d836f69571 to 7e41b064eb23 (1 revision) (flutter/flutter#134396)
2023-09-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2acd60d6baed to 04d836f69571 (1 revision) (flutter/flutter#134392)
2023-09-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 59b08263f7cc to 2acd60d6baed (1 revision) (flutter/flutter#134391)
2023-09-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from a2af0c6965be to 59b08263f7cc (1 revision) (flutter/flutter#134384)
2023-09-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 47d1a045d140 to a2af0c6965be (1 revision) (flutter/flutter#134375)
2023-09-10 dacoharkes@google.com Native assets support for MacOS and iOS (flutter/flutter#130494)
2023-09-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from feea98d6d0ae to 47d1a045d140 (1 revision) (flutter/flutter#134368)
2023-09-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4edbefa5e8f7 to feea98d6d0ae (1 revision) (flutter/flutter#134365)
2023-09-09 rmolivares@renzo-olivares.dev SelectableRegion onSelectionChange should be called when the selection changes (flutter/flutter#134215)
2023-09-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from b8afb6deacf3 to 4edbefa5e8f7 (1 revision) (flutter/flutter#134360)
2023-09-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from d1913cb6a276 to b8afb6deacf3 (1 revision) (flutter/flutter#134356)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorgalo pushed a commit to victorgalo/flutter that referenced this pull request Sep 11, 2023
@polina-c @victorgalo
Cover more tests with leak tracking. (flutter#134363)
9739c14
@HansMuller HansMuller mentioned this pull request Sep 15, 2023
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
219efce7f Cover more tests with leak tracking. (flutter/flutter#134363)
4f1a6fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai approved these changes

@Renzo-Olivares Renzo-Olivares Awaiting requested review from Renzo-Olivares

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@polina-c @chunhtai