-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable private field promotion for flutter_tools #134474
Conversation
Woohoo, excited about this! |
fd9a605
to
e9a441b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for this one!
@@ -466,7 +466,7 @@ format: true | |||
pubspecFile.writeAsStringSync(''' | |||
name: test | |||
environment: | |||
sdk: '>=3.0.0-0 <4.0.0' | |||
sdk: '>=3.2.0-0 <4.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you just grep to find all these magic strings? outside of this PR, maybe we should just have a global const string to make bumping this easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I did, yeah. That sounds like a good idea!
e9a441b
to
fd8ede2
Compare
auto label is removed for flutter/flutter/134474, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
New feature in upcoming Dart 3.2. See dart-lang/language#2020. Feature is enabled by bumping the min SDK version to 3.2.
Part of #134476.