Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SliverList example descriptions #134483

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Fix SliverList example descriptions #134483

merged 2 commits into from
Sep 12, 2023

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Sep 12, 2023

Fixes #134142

The description for the SliverList.list example was just wrong, describing something other than the sample. 🙃
Tweaked some of the language on the others while I was here.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Sep 12, 2023
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Sep 12, 2023
goderbauer
goderbauer approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 12, 2023

auto label is removed for flutter/flutter/134483, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2023
@auto-submit auto-submit bot merged commit fcba7b3 into flutter:master Sep 12, 2023
67 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
fcba7b3dc Fix SliverList example descriptions (flutter/flutter#134483)
36aec08
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
fcba7b3dc Fix SliverList example descriptions (flutter/flutter#134483)
6bb998c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
fcba7b3dc Fix SliverList example descriptions (flutter/flutter#134483)
b03db8f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
fcba7b3dc Fix SliverList example descriptions (flutter/flutter#134483)
f0dde6a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
fcba7b3dc Fix SliverList example descriptions (flutter/flutter#134483)
1c99236
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@Piinks @Mairramer
Fix SliverList example descriptions (flutter#134483)
5290d0c 
Fixes flutter#134142

The description for the SliverList.list example was just wrong, describing something other than the sample. � 
Tweaked some of the language on the others while I was here.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
fcba7b3dc Fix SliverList example descriptions (flutter/flutter#134483)
c727e9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation on SliverList.list(…) constructor has snippet not matching its description
2 participants
@Piinks @goderbauer