Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispose layers in test. #134802

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Dispose layers in test. #134802

merged 2 commits into from
Sep 15, 2023

Conversation

polina-c
Copy link
Contributor

Fixes #133939

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Sep 15, 2023
@polina-c
Copy link
Contributor Author

Google testing passed. Merging master.

Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polina-c polina-c merged commit f629dc8 into flutter:master Sep 15, 2023
65 of 67 checks passed
@polina-c polina-c deleted the PaintingContext-fix branch September 15, 2023 19:53
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 16, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 16, 2023
flutter/flutter@72b69f9...e5e36ad

2023-09-16 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 326faf1762d6 to 30b7e9ded7a0 (5 revisions) (flutter/flutter#134876)
2023-09-16 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 51e643de62aa to 326faf1762d6 (6 revisions) (flutter/flutter#134875)
2023-09-16 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from d623ecf43c66 to 51e643de62aa (5 revisions) (flutter/flutter#134865)
2023-09-16 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from c0eaf2633686 to d623ecf43c66 (5 revisions) (flutter/flutter#134861)
2023-09-16 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 5aa9db365ed6 to c0eaf2633686 (5 revisions) (flutter/flutter#134860)
2023-09-16 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 67dd12f8dfca to 5aa9db365ed6 (5 revisions) (flutter/flutter#134856)
2023-09-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 45bc4307cda3 to 67dd12f8dfca (6 revisions) (flutter/flutter#134791)
2023-09-15 47866232+chunhtai@users.noreply.github.com Makes scheme and target optional parameter when getting universal lin� (flutter/flutter#134571)
2023-09-15 polinach@google.com Dispose layers in test. (flutter/flutter#134802)
2023-09-15 31859944+LongCatIsLooong@users.noreply.github.com [Windows_android channels_integration_test] Column -> ListView (flutter/flutter#134836)
2023-09-15 30870216+gaaclarke@users.noreply.github.com moved hello_world_impeller to a 7pro (flutter/flutter#134830)
2023-09-15 dacoharkes@google.com Speed up native assets target (flutter/flutter#134523)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Sep 21, 2023
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
…r#4938)

flutter/flutter@72b69f9...e5e36ad

2023-09-16 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 326faf1762d6 to 30b7e9ded7a0 (5 revisions) (flutter/flutter#134876)
2023-09-16 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 51e643de62aa to 326faf1762d6 (6 revisions) (flutter/flutter#134875)
2023-09-16 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from d623ecf43c66 to 51e643de62aa (5 revisions) (flutter/flutter#134865)
2023-09-16 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from c0eaf2633686 to d623ecf43c66 (5 revisions) (flutter/flutter#134861)
2023-09-16 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 5aa9db365ed6 to c0eaf2633686 (5 revisions) (flutter/flutter#134860)
2023-09-16 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 67dd12f8dfca to 5aa9db365ed6 (5 revisions) (flutter/flutter#134856)
2023-09-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 45bc4307cda3 to 67dd12f8dfca (6 revisions) (flutter/flutter#134791)
2023-09-15 47866232+chunhtai@users.noreply.github.com Makes scheme and target optional parameter when getting universal lin� (flutter/flutter#134571)
2023-09-15 polinach@google.com Dispose layers in test. (flutter/flutter#134802)
2023-09-15 31859944+LongCatIsLooong@users.noreply.github.com [Windows_android channels_integration_test] Column -> ListView (flutter/flutter#134836)
2023-09-15 30870216+gaaclarke@users.noreply.github.com moved hello_world_impeller to a 7pro (flutter/flutter#134830)
2023-09-15 dacoharkes@google.com Speed up native assets target (flutter/flutter#134523)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PaintingContext creates layer that is never disposed.
2 participants