-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cover more test/widgets tests with leak tracking #11 #135231
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
a: text input
Entering text in a text field or keyboard related problems
framework
flutter/packages/flutter repository. See also f: labels.
a: animation
Animation APIs
a: accessibility
Accessibility, e.g. VoiceOver or TalkBack. (aka a11y)
f: scrolling
Viewports, list views, slivers, etc.
f: cupertino
flutter/packages/flutter/cupertino repository
labels
Sep 21, 2023
cc @polina-c |
polina-c
added
the
a: leak tracking
Issues and PRs related to memory leaks detected by leak_tracker
label
Sep 21, 2023
polina-c
approved these changes
Sep 21, 2023
@polina-c thanks for the review! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 28, 2023
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a: accessibility
Accessibility, e.g. VoiceOver or TalkBack. (aka a11y)
a: animation
Animation APIs
a: leak tracking
Issues and PRs related to memory leaks detected by leak_tracker
a: text input
Entering text in a text field or keyboard related problems
f: cupertino
flutter/packages/flutter/cupertino repository
f: scrolling
Viewports, list views, slivers, etc.
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes
testWidgets
bytestWidgetsWithLeakTracking
in number offlutter/test/widgets
tests according to the dart-lang/leak_tracker#134.Tests
text_semantics_test.dart
to usetestWidgetsWithLeakTracking
;text_test.dart
to usetestWidgetsWithLeakTracking
;texture_test.dart
to usetestWidgetsWithLeakTracking
;ticker_mode_test.dart
to usetestWidgetsWithLeakTracking
;ticker_provider_test.dart
to usetestWidgetsWithLeakTracking
;title_test.dart
to usetestWidgetsWithLeakTracking
;tracking_scroll_controller_test.dart
to usetestWidgetsWithLeakTracking
;transformed_scrollable_test.dart
to usetestWidgetsWithLeakTracking
;transitions_test.dart
to usetestWidgetsWithLeakTracking
;tree_shape_test.dart
to usetestWidgetsWithLeakTracking
;tween_animation_builder_test.dart
to usetestWidgetsWithLeakTracking
;two_dimensional_scroll_view_test.dart
to usetestWidgetsWithLeakTracking
;two_dimensional_viewport_test.dart
to usetestWidgetsWithLeakTracking
;undo_history_test.dart
to usetestWidgetsWithLeakTracking
;unique_widget_test.dart
to usetestWidgetsWithLeakTracking
;value_listenable_builder_test.dart
to usetestWidgetsWithLeakTracking
;view_test.dart
to usetestWidgetsWithLeakTracking
;visibility_test.dart
to usetestWidgetsWithLeakTracking
;wrap_test.dart
to usetestWidgetsWithLeakTracking
.Pre-launch Checklist
///
).