[a11y] Add semantics: button to bottom navigation bar items and dropdown menu items #149375

hangyujin · 2024-05-31T01:10:13Z

issue: #117997

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

chunhtai

LGTM, just one concern about the test changes

chunhtai · 2024-06-06T17:01:40Z

packages/flutter/test/material/dropdown_test.dart

@@ -1296,7 +1296,7 @@ void main() {
    ));

    // By default the hint contributes the label.
-    expect(tester.getSemantics(find.byKey(key)), matchesSemantics(
+    expect(tester.getSemantics(find.text('test')), matchesSemantics(


why this and below changes?

because semantic menu button and semantic meun item become different semantics nodes after the change.

kevmoo · 2024-06-11T18:45:54Z

Can we get this landed?

Piinks · 2024-06-12T17:25:17Z

@hangyujin FYI it looks like there are some Google testing failures here

hangyujin · 2024-06-13T17:52:19Z

I'm adding a g3 fix for Google testing failures

…nd dropdown menu items (flutter/flutter#149375)

…nd dropdown menu items" (#150445) Reverts #149375 Because it failed a g3 integration testing. b/347867286

…nd dropdown menu items (flutter/flutter#149375)

Manual roll requested by stuartmorgan@google.com flutter/flutter@ccf3abe...6c06abb 2024-06-18 magder@google.com Add test for engine artifact framework permissions (flutter/flutter#148786) 2024-06-18 32538273+ValentinVignal@users.noreply.github.com Add test for icon_button.3.dart (flutter/flutter#149988) 2024-06-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 78fdd06af541 to 74f42ca3544c (6 revisions) (flutter/flutter#150421) 2024-06-18 tessertaha@gmail.com Fix transparent `dividerColor` breaks `TabBar.tabAlignment` (flutter/flutter#150350) 2024-06-18 tessertaha@gmail.com Fix scrollable `TabBar` jittering (flutter/flutter#150041) 2024-06-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland 3: [CupertinoActionSheet] Match colors to native (#150386)" (flutter/flutter#150413) 2024-06-18 jason-simmons@users.noreply.github.com Extend the Windows web_tool_tests_1_2 shard timeout to 45 minutes (flutter/flutter#150393) 2024-06-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1c4e5e230ecb to 78fdd06af541 (3 revisions) (flutter/flutter#150403) 2024-06-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from a4f266f7eb1a to 1c4e5e230ecb (8 revisions) (flutter/flutter#150399) 2024-06-18 parlough@gmail.com Rename doc file to use standard hyphens (flutter/flutter#150314) 2024-06-17 120297255+PurplePolyhedron@users.noreply.github.com Fix typo in `SliverLayoutDimensions.hashCode` where not all properties are used in the hash code. (flutter/flutter#150306) 2024-06-17 srawlins@google.com Fix doc comment references to 'this' (flutter/flutter#150379) 2024-06-17 Lexycon@users.noreply.github.com Add 'fail-fast' argument to flutter test (flutter/flutter#149587) 2024-06-17 dev@alestiago.com Update matchesGoldenFile documentation reference to goldenFileComparator (flutter/flutter#150343) 2024-06-17 dkwingsmt@users.noreply.github.com Reland 3: [CupertinoActionSheet] Match colors to native (flutter/flutter#150386) 2024-06-17 jhy03261997@gmail.com [a11y] Add semantics: button to bottom navigation bar items and dropdown menu items (flutter/flutter#149375) 2024-06-17 yinxulolol@gmail.com Reland "sliverGridDelegate mainAxisExtent add assert (#148470)" (flutter/flutter#149720) 2024-06-17 36861262+QuncCccccc@users.noreply.github.com `ScaffoldBackgroundColor` should default to `ColorScheme.surface` (flutter/flutter#149772) 2024-06-17 katelovett@google.com Reland TreeSliver (flutter/flutter#149839) 2024-06-17 dkwingsmt@users.noreply.github.com Reland: [CupertinoActionSheet] Add sliding tap gesture (flutter/flutter#150219) 2024-06-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5989f0215fed to a4f266f7eb1a (1 revision) (flutter/flutter#150377) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

issue: #117997 This is a partial reland of #149375 with updated g3fix cl/642457545 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…utter#150578) issue: flutter#117997 This is a partial reland of flutter#149375 with updated g3fix cl/642457545 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…nd dropdown menu items (flutter/flutter#149375)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels May 31, 2024

hangyujin requested a review from chunhtai May 31, 2024 01:11

chunhtai reviewed Jun 6, 2024

View reviewed changes

chunhtai approved these changes Jun 6, 2024

View reviewed changes

kevmoo added the customer: castaway label Jun 11, 2024

hangyujin force-pushed the fix-117997 branch 2 times, most recently from 915549b to be2a005 Compare June 15, 2024 02:00

hangyujin added 12 commits June 17, 2024 10:23

add button semantics

7c68040

add test

883fd12

semantics change

aa0c9e3

Update dropdown.dart

f9c643d

lint

adfe698

Update dropdown.dart

4f49f44

lint

2f99959

update semantic and tests

e2b15c7

Update dropdown.dart

1651877

lint

6a764ae

lint

9444cfd

lint

4353b4b

hangyujin force-pushed the fix-117997 branch from 68679b8 to 4353b4b Compare June 17, 2024 17:23

hangyujin added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 17, 2024

auto-submit bot merged commit 21a12f6 into flutter:master Jun 17, 2024
72 checks passed

engine-flutter-autoroll mentioned this pull request Jun 18, 2024

Roll Flutter from ccf3abe94047 to b44c67e2e893 (19 revisions) flutter/packages#6944

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2024

21a12f6 [a11y] Add semantics: button to bottom navigation bar items a…

34585a3

…nd dropdown menu items (flutter/flutter#149375)

engine-flutter-autoroll mentioned this pull request Jun 18, 2024

Roll Flutter from ccf3abe94047 to f2c48afbb1cf (20 revisions) flutter/packages#6945

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2024

21a12f6 [a11y] Add semantics: button to bottom navigation bar items a…

5b37897

…nd dropdown menu items (flutter/flutter#149375)

engine-flutter-autoroll mentioned this pull request Jun 18, 2024

Roll Flutter from ccf3abe94047 to 6c06abbb5576 (21 revisions) flutter/packages#6947

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2024

21a12f6 [a11y] Add semantics: button to bottom navigation bar items a…

8a618f7

…nd dropdown menu items (flutter/flutter#149375)

hangyujin mentioned this pull request Jun 18, 2024

Revert "[a11y] Add semantics: button to bottom navigation bar items and dropdown menu items" #150445

Merged

engine-flutter-autoroll mentioned this pull request Jun 18, 2024

Roll Flutter from ccf3abe94047 to f54dfcd27db8 (22 revisions) flutter/packages#6948

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2024

21a12f6 [a11y] Add semantics: button to bottom navigation bar items a…

792d334

…nd dropdown menu items (flutter/flutter#149375)

hangyujin added a commit that referenced this pull request Jun 18, 2024

Revert "[a11y] Add semantics: button to bottom navigation bar items a…

835ff20

…nd dropdown menu items" (#150445) Reverts #149375 Because it failed a g3 integration testing. b/347867286

engine-flutter-autoroll mentioned this pull request Jun 19, 2024

Roll Flutter from ccf3abe94047 to 71ac7f55b3dd (29 revisions) flutter/packages#6950

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2024

21a12f6 [a11y] Add semantics: button to bottom navigation bar items a…

8c859d2

…nd dropdown menu items (flutter/flutter#149375)

engine-flutter-autoroll mentioned this pull request Jun 19, 2024

Roll Flutter from ccf3abe94047 to 71ac7f55b3dd (29 revisions) flutter/packages#6951

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2024

21a12f6 [a11y] Add semantics: button to bottom navigation bar items a…

31074dc

…nd dropdown menu items (flutter/flutter#149375)

engine-flutter-autoroll mentioned this pull request Jun 20, 2024

Manual roll Flutter from ccf3abe94047 to 6c06abbb5576 (21 revisions) flutter/packages#6954

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 20, 2024

21a12f6 [a11y] Add semantics: button to bottom navigation bar items a…

0554707

…nd dropdown menu items (flutter/flutter#149375)

engine-flutter-autoroll mentioned this pull request Jun 20, 2024

Roll Flutter from ccf3abe94047 to bfdcb51643b3 (32 revisions) flutter/packages#6955

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 20, 2024

21a12f6 [a11y] Add semantics: button to bottom navigation bar items a…

681bd94

…nd dropdown menu items (flutter/flutter#149375)

engine-flutter-autoroll mentioned this pull request Jun 20, 2024

Roll Flutter from ccf3abe94047 to 0674f46e9fde (33 revisions) flutter/packages#6956

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 20, 2024

21a12f6 [a11y] Add semantics: button to bottom navigation bar items a…

f401264

…nd dropdown menu items (flutter/flutter#149375)

This was referenced Jun 25, 2024

[a11y] Reland [#149375 ] Update semantics in dropdown.dart #150578

Merged

[a11y] Update semantics in bottom_navigation_bar.dart #150576

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

21a12f6 [a11y] Add semantics: button to bottom navigation bar items a…

4d482f9

…nd dropdown menu items (flutter/flutter#149375)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[a11y] Add semantics: button to bottom navigation bar items and dropdown menu items #149375

[a11y] Add semantics: button to bottom navigation bar items and dropdown menu items #149375

hangyujin commented May 31, 2024

chunhtai left a comment

chunhtai Jun 6, 2024

hangyujin Jun 17, 2024

kevmoo commented Jun 11, 2024

Piinks commented Jun 12, 2024

hangyujin commented Jun 13, 2024

[a11y] Add semantics: button to bottom navigation bar items and dropdown menu items #149375

[a11y] Add semantics: button to bottom navigation bar items and dropdown menu items #149375

Conversation

hangyujin commented May 31, 2024

Pre-launch Checklist

chunhtai left a comment

Choose a reason for hiding this comment

chunhtai Jun 6, 2024

Choose a reason for hiding this comment

hangyujin Jun 17, 2024

Choose a reason for hiding this comment

kevmoo commented Jun 11, 2024

Piinks commented Jun 12, 2024

hangyujin commented Jun 13, 2024