ButtonBar RTL docs clarification #24264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HansMuller Let me know if this is a good place for this line, or if there is anything else I can add to clarify. |
HansMuller
reviewed
Nov 13, 2018
| @@ -12,7 +12,8 @@ import 'raised_button.dart'; | |||
| /// A horizontal arrangement of buttons. | |||
There was a problem hiding this comment.
An end-aligned row of buttons.
| @@ -12,7 +12,8 @@ import 'raised_button.dart'; | |||
| /// A horizontal arrangement of buttons. | |||
| /// | |||
| /// Places the buttons horizontally according to the padding in the current | |||
| /// [ButtonTheme]. | |||
| /// [ButtonTheme]. Alignment and order of children are reversed between RTL and | |||
There was a problem hiding this comment.
It might be best to be more specific here (since in one sense the Row's "alignment" doesn't change, it's always MainAxisAlignment.end).
The children are laid out in a [Row] with [MainAxisAlignment.end]. When the [Directionality] is [TextDirection.ltr] the button bar's children are right justified and the last child becomes the rightmost child. When the [Directionality] [TextDirection.rtl] the children are left justified and the last child becomes the leftmost child.
justinmc
force-pushed
the
button-bar-rtl
branch
from
28ce249
to
6222fb9
Compare
|
@HansMuller Updated with your comments. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23217