Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch tool tests to build runner #28759

Merged
merged 2 commits into from
Mar 2, 2019

Conversation

jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Mar 2, 2019

Description

Switch tool tests to use build_runner. The test execution should be noticeably faster, with the trade-off of doing compilation up front. The compilation artifacts can be shared across shards though, which should allow us to increase overall test throughput.

shard pub test build_runner test
tool_tests-linux 30 min 24 min
tool_tests-windows 35 min 32 min
tool_tests-macos 30 min 25 min

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams merged commit d91cfff into flutter:master Mar 2, 2019
@jonahwilliams jonahwilliams deleted the use_build_runner branch March 2, 2019 03:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants