[flutter_migrate] Start command and executables #2735
Conversation
GaryQian
force-pushed
the
migratestart
branch
from
10e9ca6
to
44e9915
Compare
GaryQian
force-pushed
the
migratestart
branch
from
44e9915
to
c4364ab
Compare
GaryQian
changed the title
| @@ -55,11 +55,8 @@ bool _skipped(String localPath, FileSystem fileSystem, | |||
| } | |||
| } | |||
| if (skippedPrefixes != null) { | |||
| final Iterable<String> canonicalizedSkippedPrefixes = | |||
There was a problem hiding this comment.
Don't canonicalize, as it attempts to convert to absolute paths and this interferes with prefixing.
There was a problem hiding this comment.
would we be susceptible to differences in path separator or ASCII case?
There was a problem hiding this comment.
Let me try normalize(), maybe that's what we are looking for.
There was a problem hiding this comment.
I think a combination of path separator conversion and the normalize() function should be safe
| argParser.addOption( | ||
| 'base-app-directory', | ||
| help: | ||
| 'The directory containing the base reference app. This is used as the common ancestor in a 3 way merge. ' |
There was a problem hiding this comment.
should we only show this in verbose mode?
There was a problem hiding this comment.
or not at all? i don't imagine end users should be using this?
There was a problem hiding this comment.
The use case for this is for people migrating many projects at once. By providing the base and target app dirs, the tool will skip over the download of the sdk and flutter-creating the project steps, which can save a lot of time.
I think putting this under verbose makes sense.
| valueHelp: 'path', | ||
| ); | ||
| argParser.addOption( | ||
| 'target-app-directory', |
|
Approved % open comments. |
.cirrus.yml
Outdated
| @@ -256,7 +256,7 @@ task: | |||
| zone: us-central1-a | |||
| namespace: default | |||
| cpu: 4 | |||
| memory: 12G | |||
| memory: 14G | |||
There was a problem hiding this comment.
Flutter migrate tests fail on android gradle build due to OOM
GaryQian
force-pushed
the
migratestart
branch
from
e621224
to
37e8aff
Compare
GaryQian
added
the
autosubmit
The
startcommand and executable framework to allow the commands to be called.The migrate tool is considered usable after this PR.
The tests include E2E tests that mocks a full migration process and exercises all of the sub commands.
This is dependent on #2734