Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Commit

Permalink
Fix the message strings for xcodeMissing and xcodeIncomplete (#117922)
Browse files Browse the repository at this point in the history
* Add macOS to xcodeMissing and xcodeIncomplete

* And unit test
  • Loading branch information
peixinli authored Jan 4, 2023
1 parent 63653e8 commit 906761c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/flutter_tools/lib/src/base/user_messages.dart
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,10 @@ class UserMessages {
'Launch Xcode and install additional required components when prompted or run:\n'
' sudo xcodebuild -runFirstLaunch';
String get xcodeMissing =>
'Xcode not installed; this is necessary for iOS development.\n'
'Xcode not installed; this is necessary for iOS and macOS development.\n'
'Download at https://developer.apple.com/xcode/download/.';
String get xcodeIncomplete =>
'Xcode installation is incomplete; a full installation is necessary for iOS development.\n'
'Xcode installation is incomplete; a full installation is necessary for iOS and macOS development.\n'
'Download at: https://developer.apple.com/xcode/download/\n'
'Or install Xcode via the App Store.\n'
'Once installed, run:\n'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,10 @@ void main() {
checkInstallationURL((Platform platform) => userMessages.androidSdkBuildToolsOutdated(0, '', platform));
checkInstallationURL((Platform platform) => userMessages.androidStudioInstallation(platform));
});

testWithoutContext('Xcode installation instructions', () {
final UserMessages userMessages = UserMessages();
expect(userMessages.xcodeMissing, contains('iOS and macOS'));
expect(userMessages.xcodeIncomplete, contains('iOS and macOS'));
});
}

0 comments on commit 906761c

Please sign in to comment.