This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Migrate independent plugins to AndroidX #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original Android support libraries have been deprecated in favor of AndroidX. This migration shouldn't affect behavior in a user noticeable way, but does require plugin users to also migrate their app. See [migrating to AndroidX](https://developer.android.com/jetpack/androidx/migrate). Migrates all of our plugins without pub interdepencies to use the new AndroidX support libraries. At least one followup PR will be required to update the remaining plugins that depend on these after this is pushed to pub. - android_intent - battery - connectivity - device_info - firebase_auth - firebase_core - google_maps_flutter - google_sign_in - image_picker - in_app_purchase - local_auth - location_background - package_info - path_provider - quick_actions - sensors - share - shared_preferences - url_launcher - video_player - webview_flutter
mklim
changed the title
|
I tested this locally using AndroidX plugin with current Flutter and it looks good. Should we bump the gradle plugins while we're at it to 3.3.0? As in flutter/flutter#26913 It looks like this all works and builds, so maybe we could do that as a separate patch. Either way, LGTM |
dnfield
reviewed
Jan 24, 2019
|
Does this conflict with our mandate to keep plugins working with the last stable flutter release? |
I've spot checked some of the example apps with |
|
@jonahwilliams this appears to be backwards compatible (plugins using AndroidX seem to work with Flutter using older support libs), although in the reverse direction it seems to not be (e.g. if someone is using AndroidX in their app, they can't use plugins on the older support libs). |
bbedward
added a commit
to bbedward/plugins
that referenced
this pull request
Jan 30, 2019
This reverts commit 59e84d8.
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
The original Android support libraries have been deprecated in favor of AndroidX. This migration shouldn't affect behavior in a user noticeable way, but does require plugin users to also migrate their app. See [migrating to AndroidX](https://developer.android.com/jetpack/androidx/migrate). Migrates all of our plugins without pub interdepencies to use the new AndroidX support libraries. At least one followup PR will be required to update the remaining plugins that depend on these after this is pushed to pub. - android_intent - battery - connectivity - device_info - firebase_auth - firebase_core - google_maps_flutter - google_sign_in - image_picker - in_app_purchase - local_auth - location_background - package_info - path_provider - quick_actions - sensors - share - shared_preferences - url_launcher - video_player - webview_flutter
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
This reverts commit 189f3d2.
This was referenced Oct 17, 2019
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
The original Android support libraries have been deprecated in favor of AndroidX. This migration shouldn't affect behavior in a user noticeable way, but does require plugin users to also migrate their app. See [migrating to AndroidX](https://developer.android.com/jetpack/androidx/migrate). Migrates all of our plugins without pub interdepencies to use the new AndroidX support libraries. At least one followup PR will be required to update the remaining plugins that depend on these after this is pushed to pub. - android_intent - battery - connectivity - device_info - firebase_auth - firebase_core - google_maps_flutter - google_sign_in - image_picker - in_app_purchase - local_auth - location_background - package_info - path_provider - quick_actions - sensors - share - shared_preferences - url_launcher - video_player - webview_flutter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original Android support libraries have been deprecated in favor of
AndroidX. This migration shouldn't affect behavior in a user noticeable
way, but does require plugin users to also migrate their app. See
migrating to AndroidX.
Migrates all of our plugins without pub interdepencies to use the new
AndroidX support libraries. At least one followup PR will be required to
update the remaining plugins that depend on these after this is pushed
to pub.
flutter/flutter#23995