This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Update GoogleSignInPlugin to use and expose a Delegate #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
approved these changes
Jun 29, 2017
| try { | ||
| if (googleApiClient != null) { | ||
| // This can happen if the scopes change, or a full restart or hot reload | ||
| googleApiClient = null; |
There was a problem hiding this comment.
What does setting this to null actually help with?
There was a problem hiding this comment.
Vestigial bit of code, no doubt (this PR just moved around existing code). I'll remove it.
This enables other Android plugins to wrap Google sign-in functionality. The immediate use case for this is the internal Google SSO-auth plugin, where on Android, it uses the same client libraries at third-party apps and shares a bunch of code with third-party sign-in.
HansMuller
pushed a commit
to HansMuller/plugins
that referenced
this pull request
Jun 30, 2017
This enables other Android plugins to wrap Google sign-in functionality. The immediate use case for this is the internal Google SSO-auth plugin, where on Android, it uses the same client libraries at third-party apps and shares a bunch of code with third-party sign-in.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables other Android plugins to wrap Google sign-in
functionality. The immediate use case for this is the internal
Google SSO-auth plugin, where on Android, it uses the same
client libraries at third-party apps and shares a bunch of
code with third-party sign-in.