This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[webview_flutter] Support for loading progress tracking #2151
[webview_flutter] Support for loading progress tracking #2151
Changes from 11 commits
2375fa7
704cc75
90b47c1
a795c90
a618831
e201d3c
1fe7ef4
03a6307
b1052b4
5cd61b2
f153499
19d697e
9ceea3c
a5906b3
a357555
eb809fc
636ad6f
677bad9
25af806
a020da2
07ab322
f3de98b
76e2d76
a778bf3
0090288
a6f2b53
a706d3e
2897586
24c77c2
069af29
6fa576d
7d7c400
11e6ade
1747608
16c7d33
73d09be
a9bcf56
d9438f1
6cc00fc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we refactor the
WebChromeClient
out to somewhere else? Maybe an instance var? We likely will add more to theWebChromeClient
in the future and it would be cleaner to have it somewhere stand alone.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have another PR which is going to add a WebChromeClient to the webview: #2991. There will be conflicts once the other PR lands.
Maybe let's wait for the other PR to land and rebase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we refactor this code into
FlutterWebChromeClient
instead of creating a newWebChromeClient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this used anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, this flag wasn't used properly. I've updated the PR so that progress changes are sent to the method channel only if
hasProgressTracking
istrue
.