Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add deprecation suppression for plugins marked with -Werror #3072

Merged
merged 4 commits into from
Sep 23, 2020

Conversation

xster
Copy link
Member

@xster xster commented Sep 23, 2020

Description

I'm marking the v1 embeddings deprecated flutter/engine#20868

Since there are 3 versions involved, the app, the engine and the plugin, we intentionally want to deprecate the plugins and the engine last to not break the app users. However, the engine is connected to both the app and the plugin. Adding deprecation ignores in the plugin lets us deprecate APIs on the engine, showing warnings to the app users while still letting plugins with V1 handling build.

Related Issues

flutter/flutter#43298

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % ci failure on versioning.

@@ -1,3 +1,7 @@
## 1.0.5+1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 1.0.6

@xster xster merged commit 0e27dc2 into flutter:master Sep 23, 2020
@xster xster deleted the v1-deprecation-warning branch September 23, 2020 07:51
@xster xster mentioned this pull request Sep 23, 2020
13 tasks
danielroek pushed a commit to Baseflow/flutter-plugins that referenced this pull request Oct 1, 2020
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants