Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[share] Replace deprecated Environment.getExternalStorageDirectory() call on Android. #3152

Merged
merged 2 commits into from
Oct 14, 2020
Merged

[share] Replace deprecated Environment.getExternalStorageDirectory() call on Android. #3152

merged 2 commits into from
Oct 14, 2020

Conversation

hamdikahloun
Copy link
Member

Description

  • Replace deprecated Environment.getExternalStorageDirectory() call on Android.

  • Upgrade to Android Gradle plugin 3.5.0 & target API level 29.

Related Issues

flutter/flutter#68011
flutter/flutter#66513

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Oct 14, 2020
dnfield
dnfield approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This seems to address at least one of the problems in the linked bug, but we still don't support Android Gradle Plugin 4+. Still it's good to get rid of deprecated API usages.

@dnfield dnfield merged commit 2866574 into flutter:master Oct 14, 2020
@hamdikahloun hamdikahloun mentioned this pull request Oct 14, 2020
Closed
blasten pushed a commit that referenced this pull request Oct 15, 2020
@hamdikahloun @mvanbeusekom
@kevmoo @CareF @bparrishMines @creativecreatorormaybenot @jmagman @stuartmorgan
Sync nnbd branch (#3157)
58ac43a 
* Android Code Inspection and Clean up (#3117)

* [in_app_purchase] Android Code Inspection and Clean up (#3120)

* Android Code Inspection and Clean up

* Format

* [video_player] Fix SSLProtocolException for low API version (#3122)

* [camera] Set audio encoding bitrate when recording video (#3124)

Fixes flutter/flutter#38787

* Fix links in package example readmes (#3130)

http://flutter.io/ -> https://flutter.dev/

* [integration_test] Add watchPerformance (#3116)

* add watchPerformance

* [wifi_info_flutter] [wifi_info_flutter_platform_interface] Initial commit for `wifi_info_flutter` plugin and platform interface (#3129)

* [video_player] fix Timer Leak (#3119)

* [in_app_purchase] Add example test target to Podfile, add OCMock dependency (#3145)

* Add linux directory to examples (#3064)

When Linux support was added to these plugins, the app template wasn't
yet stabilized, so was not checked in. Now that it is stable, this adds
them so that the plugin_tools workaround that created them on each run
can be removed.

Other than CHANGELOG.md updates and updating the verison in
pubspec.yaml, this is purely the result of running 'flutter create .' in
the example/ folders and adding the resulting linux/ directories.

* [wifi_info_flutter_plugin_interface] implement wifi platform interface (#3134)

* [share] Replace deprecated Environment.getExternalStorageDirectory() call on Android. (#3152)

* Android API 29 & 30

* Update Version

* Update android sdk version to 29 for all mobile plugins. (#3042)

* [google_sign_in]  fix merge error in CHANGELOG (#3153)

Co-authored-by: Hamdi Kahloun <32666446+hamdikahloun@users.noreply.github.com>
Co-authored-by: Maurits van Beusekom <maurits@baseflow.com>
Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
Co-authored-by: Ming Lyu (CareF) <minglyu@google.com>
Co-authored-by: Maurice Parrish <bmparr@google.com>
Co-authored-by: creativecreatorormaybenot <creativecreatorormaybenot@gmail.com>
Co-authored-by: Jenn Magder <magder@google.com>
Co-authored-by: stuartmorgan <stuartmorgan@google.com>
Co-authored-by: Chris Yang <ychris@google.com>
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
@hamdikahloun
[share] Replace deprecated Environment.getExternalStorageDirectory() …
f39af02 
…call on Android. (flutter#3152)

* Android API 29 & 30

* Update Version
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dnfield dnfield dnfield approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamdikahloun @dnfield