This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[url_launcher] Fix PlatformException introduced in nnbd release #3307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes PlatformException
NOT_A_WEB_SCHEME
forceSafariVC
has previously been null (not true) by default.Since the description (below) still says that it is false (unset) by default, I think, it is desired to set it to false (keeping it as true by default would need updates to the description as well as the if clause causing the PlatformException:
Related Issues
flutter/flutter#71725
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?