Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Remove all the examples' podfiles #340

Merged
merged 2 commits into from
Jan 30, 2018
Merged

Conversation

xster
Copy link
Member

@xster xster commented Jan 4, 2018

So the podfile template can be exercised instead of checking in stale ones

Copy link
Contributor

@mravn-google mravn-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to update relevant .gitignore file(s) to ignore the generated Podfiles. Otherwise, git clone + run example app will leave a dirty workspace.

While we're at it, we may want to make sure that the new Flutter/flutter_assets folder is ignored in iOS example projects, e.g. here.

@xster
Copy link
Member Author

xster commented Jan 9, 2018

Did flutter assets in a separate PR #350

The Podfiles are a bit inconvenient but I'd argue it's the 'right' behaviour to have the workspace be in a dirty state after running building an example. If you want share the example with other people, the Podfile needs to be 'materialized' so everyone's builds are consistent.

@mravn-google
Copy link
Contributor

The regular project templates surely do not gitignore the Podfiles. But for the template instantiations checked into our own repos, we've taken the approach so far to set them up to be clean after flutter run. The Gradle wrapper executables for instance are in gitignore for this reason.

@xster
Copy link
Member Author

xster commented Jan 18, 2018

Ah I see. Makes sense to keep in sync with gradle wrappers. Done

@mravn-google
Copy link
Contributor

Thanks. I think we can merge this now?

@Hixie
Copy link
Contributor

Hixie commented Jan 30, 2018

@xster is this ready to land?

@xster
Copy link
Member Author

xster commented Jan 30, 2018

My bad, I thought I already merged it.

@xster xster merged commit 9a495f0 into flutter:master Jan 30, 2018
@xster xster deleted the remove-podfile branch January 30, 2018 19:31
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
* remove pod files

* git ignore podfile too in examples
Akachu pushed a commit to Akachu/flutter_camera that referenced this pull request Apr 27, 2020
* remove pod files

* git ignore podfile too in examples
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants