Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker] Migrate Image_picker_platform interface to Null Safety #3508

Closed

Conversation

Sameerkash
Copy link
Contributor

Migrate Image_picker_platform interface to Null Safety

Related to #75162

All existing tests are passing

Pre-launch Checklist

  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@Hixie
Copy link
Contributor

Hixie commented Feb 4, 2021

test-exempt: refactoring with no logical change

@Sameerkash
Copy link
Contributor Author

@stuartmorgan Any hints on the failing checks? is it the CI config?

@stuartmorgan stuartmorgan added the nnbd Support for null safety label Feb 4, 2021
@cyanglaz
Copy link
Contributor

cyanglaz commented Feb 4, 2021

@Sameerkash Thank you for the PR! This is being done in #3492 and we are almost landing the PR. I'm going to close this one :)

@cyanglaz cyanglaz closed this Feb 4, 2021
@cyanglaz
Copy link
Contributor

cyanglaz commented Feb 4, 2021

@Sameerkash If you'd like to work on the migration for the image_picker plugin after #3492, I'll be super happy to review it! :)

@stuartmorgan
Copy link
Contributor

@Sameerkash Apologies for the duplicated work here; I tried to capture in-progress work when filing all of the bugs, but missed #3492 when filing that issue.

@Sameerkash
Copy link
Contributor Author

@Sameerkash If you'd like to work on the migration for the image_picker plugin after #3492, I'll be super happy to review it! :)

Yes. I would like to @cyanglaz
I'll start asap. Should be up in a day.

@Sameerkash
Copy link
Contributor Author

@Sameerkash Apologies for the duplicated work here; I tried to capture in-progress work when filing all of the bugs, but missed #3492 when filing that issue.

It's okay!

@cyanglaz
Copy link
Contributor

cyanglaz commented Feb 5, 2021

Yes. I would like to @cyanglaz
I'll start asap. Should be up in a day.

Please tag me on the PR! I'll be happy to review it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes nnbd Support for null safety p: image_picker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants