This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Run firebase test in flutter-cirrus #4332
Merged
fluttergithubbot
merged 9 commits into
flutter:master
from
keyonghan:test_firebaselab_key
Sep 15, 2021
Merged
Run firebase test in flutter-cirrus #4332
fluttergithubbot
merged 9 commits into
flutter:master
from
keyonghan:test_firebaselab_key
Sep 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyonghan
force-pushed
the
test_firebaselab_key
branch
2 times, most recently
from
September 13, 2021 23:48
10504a1
to
d260f2e
Compare
godofredoc
approved these changes
Sep 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Keyong for the cleanup.
stuartmorgan
approved these changes
Sep 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
godofredoc
approved these changes
Sep 15, 2021
You'll need to sync with master to fix the web CI |
keyonghan
force-pushed
the
test_firebaselab_key
branch
from
September 15, 2021 03:55
b1295ee
to
73c79be
Compare
keyonghan
added
the
waiting for tree to go green
(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
label
Sep 15, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 15, 2021
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 15, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Sep 27, 2021
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla: yes
waiting for tree to go green
(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR try migrating firebase test to run in
flutter-cirrus
project, instead offlutter-infra
project.Context: b/197632425