Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Run firebase test in flutter-cirrus #4332

Merged
merged 9 commits into from
Sep 15, 2021

Conversation

keyonghan
Copy link
Contributor

@keyonghan keyonghan commented Sep 10, 2021

This PR try migrating firebase test to run in flutter-cirrus project, instead of flutter-infra project.

Context: b/197632425

@google-cla google-cla bot added the cla: yes label Sep 10, 2021
@keyonghan keyonghan force-pushed the test_firebaselab_key branch 2 times, most recently from 10504a1 to d260f2e Compare September 13, 2021 23:48
@keyonghan keyonghan changed the title Use flutter-cirrus key Run firebase test in flutter-cirrus Sep 14, 2021
Copy link
Contributor

@godofredoc godofredoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Keyong for the cleanup.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan
Copy link
Contributor

You'll need to sync with master to fix the web CI

@keyonghan keyonghan added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Sep 15, 2021
@fluttergithubbot fluttergithubbot merged commit 5f1c83e into flutter:master Sep 15, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 15, 2021
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Sep 15, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants