This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[video_player] Platform interface changes to fix Android rotation for videos recorded in landscapeRight #4634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
stuartmorgan
approved these changes
Jan 21, 2022
There was a problem hiding this comment.
LGTM
@gaaclarke for secondary review (see PR linked from method description for the context; it's probably a good idea to do a high-level review of that PR first in case you have concerns about the approach).
|
@gaaclarke Ping? |
gaaclarke
reviewed
Feb 15, 2022
packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart
Show resolved
Hide resolved
packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart
Outdated
Show resolved
Hide resolved
github-actions
bot
added
p: camera
p: espresso
p: file_selector
p: flutter_plugin_android_lifecycle
p: google_maps_flutter
p: google_sign_in
p: image_picker
p: in_app_purchase
p: ios_platform_images
p: local_auth
p: path_provider
p: plugin_platform_interface
p: quick_actions
p: shared_preferences
p: url_launcher
p: webview_flutter
|
@gaaclarke @stuartmorgan I believe this is ready to merge now. I changed from radians to degrees. Thanks! |
stuartmorgan
approved these changes
Mar 22, 2022
packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart
Outdated
Show resolved
Hide resolved
|
Thanks @stuartmorgan ! I applied the nit. Could this please be merged soon? |
gaaclarke
approved these changes
Mar 22, 2022
stuartmorgan
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 23, 2022
…tation for videos recorded in landscapeRight (flutter/plugins#4634)
11 tasks
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
… videos recorded in landscapeRight (flutter#4634)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform interface changes required for #3820 (review)
List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#60327
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.