This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[quick_actions] Extract iOS implementation into a separate package. #4702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvanbeusekom
force-pushed
the
issue/94224_quick_actions_ios
branch
from
b6ca84a
to
eb727c8
Compare
11 tasks
mvanbeusekom
force-pushed
the
issue/94224_quick_actions_ios
branch
from
eb727c8
to
12f2f60
Compare
stuartmorgan
suggested changes
Feb 7, 2022
packages/quick_actions/quick_actions_ios/example/test_driver/integration_test.dart
Outdated
Show resolved
Hide resolved
packages/quick_actions/quick_actions_ios/lib/quick_actions_ios.dart
Outdated
Show resolved
Hide resolved
packages/quick_actions/quick_actions_ios/ios/Classes/FLTQuickActionsPlugin.m
Outdated
Show resolved
Hide resolved
Creates a new `quick_actions_ios` directory and adds the following meta-data files: - `AUTHORS`: copied from the `quick_actions` package and added my name; - `CHANGELOG.md`: new file adding description for release 0.6.0+9; - `LICENSE`: copied from the `quick_actions` package; - `README.md`: new file adding the standard platform implementation description; - `pubspec.yaml`: new file adding package meta-data for the `quick_actions_ios` package.
A one to one copy of the `quick_actions/ios` folder to `quick_actions_ios/` using the following command: ``` cp -R ./quick_actions/ios ./quick_actions_ios/ ```
For the Cocaopod package to be registered correctly the .podspec file name needs to match the name of the Flutter package.
This commit makes a direct copy of the `quick_actions/example` app to the `quick_actions_ios` package. After the copy the `example/android` folder is removed as it doesn't serve a purpose in the WKWebView specific package. Commands run where: ``` cp -R ./quick_actions/example ./quick_actions_ios/ rm -rf ./quick_actions_ios/example/ios ```
Duplicates the default method channel implementation from the platform interface package into the iOS specific package (see issue flutter/flutter#94224).
Updates the method channel implementation by: - Renaming the class from `MethodChannelQuickActions` to `QuickActionsIos`; - Adding implementation of the `registerWith` method; - Renaming the method channel on the Dart side.
Duplicates the method channel implementation tests and update them so they test the `QuickActionsIos` class (see also issue flutter/flutter#94224).
Updates the code in example app to work with the new quick_actions_ios package.
Exclude the quick_actions_ios package from the build all plugins app CI step as it currently conflicts with the ios implementation that is still part of the quick_actions package.
mvanbeusekom
force-pushed
the
issue/94224_quick_actions_ios
branch
2 times, most recently
from
a45e70c
to
ee28283
Compare
mvanbeusekom
force-pushed
the
issue/94224_quick_actions_ios
branch
from
ee28283
to
4d25e0f
Compare
stuartmorgan
approved these changes
Feb 8, 2022
mvanbeusekom
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the native iOS implementation from the quick_actions package into its own quick_actions_ios package. I also duplicated the method channel implementation as suggested in issue flutter/flutter#94224.
Temporarily marks quick_actions as unpublishable to allow the implementations to be moved, rather than copied and deleted, in order to better preserve git history. A follow-up PR will restore it to publishable form.
Pre-launch Checklist
dart format.)[shared_preferences]///).