Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Switch app-facing package to new analysis options #4808

Merged
merged 7 commits into from
Feb 14, 2022
Merged

[camera] Switch app-facing package to new analysis options #4808

merged 7 commits into from
Feb 14, 2022

Conversation

stuartmorgan
Copy link
Contributor

Switches from legacy analysis options to current analysis options,
fixing all analysis issues it exposed.

Part of flutter/flutter#76229

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

mvanbeusekom
mvanbeusekom approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the import 'package:pedantic/pedantic.dart'; line in lib/src/camera_controller.dart which should be removed.

Removing this line locally resolves the compile error and also allows me to run all tests successfully.

@stuartmorgan
Copy link
Contributor Author

Odd, I wonder why there was an import in the first place.

@stuartmorgan stuartmorgan added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Feb 14, 2022
@fluttergithubbot fluttergithubbot merged commit e332159 into flutter:main Feb 14, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2022
@engine-flutter-autoroll
e33215959 [camera] Switch app-facing package to new analysis options (f…
8d892d9 
…lutter/plugins#4808)
stuartmorgan added a commit to stuartmorgan/plugins that referenced this pull request Feb 17, 2022
@stuartmorgan
[camera] Restore compatibility with older Flutter
6c15efd 
flutter#4808 accidentally broke
compatibility with pre-2.10 version of Flutter (without a corresponding
min version change). This restores compatibility, since doing so is
trivial.

Fixes flutter/flutter#98660
@stuartmorgan
Copy link
Contributor Author

Odd, I wonder why there was an import in the first place.

The answer turns out to be flutter/flutter#98660

@stuartmorgan stuartmorgan mentioned this pull request Feb 17, 2022
Merged
11 tasks
@stuartmorgan stuartmorgan deleted the analysis-camera branch April 19, 2022 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mvanbeusekom mvanbeusekom mvanbeusekom approved these changes

Assignees
No one assigned
Labels
p: camera waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stuartmorgan @mvanbeusekom @fluttergithubbot