Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[various] Remove pedantic #6179

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Conversation

stuartmorgan
Copy link
Contributor

We had pedantic in package pubspecs because it was used by the legacy
analysis options, but those no longer exist; the respository no longer
has any dependency on pedantic. In some cases we cleaned this up as we
migrated packages, but this cleans up all the remaining dependencies
that we forgot.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

We had `pedantic` in package pubspecs because it was used by the legacy
analysis options, but those no longer exist; the respository no longer
has any dependency on `pedantic`. In some cases we cleaned this up as we
migrated packages, but this cleans up all the remaining dependencies
that we forgot.
@stuartmorgan
Copy link
Contributor Author

No version changes because removing dev_dependencies doesn't affect client.
No CHANGELOG change because removing a dev dependency that wasn't being used anyway is uninteresting.

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 3, 2022
@auto-submit
Copy link

auto-submit bot commented Aug 3, 2022

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 3, 2022
@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 3, 2022
@auto-submit auto-submit bot merged commit 5c5d7ae into flutter:main Aug 3, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 4, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 4, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 4, 2022
yutaaraki-toydium pushed a commit to yutaaraki-toydium/plugins that referenced this pull request Aug 12, 2022
moisefeelin pushed a commit to feelinproject/plugins that referenced this pull request Aug 26, 2022
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants