[file_selector] Add getDirectoryPaths implementation for macOS #7115
Conversation
VanesaOshiro
force-pushed
the
66978-add-get-multiple-directories-for-macos-
branch
from
3500291
to
419f5c8
Compare
There was a problem hiding this comment.
LGTM with nits, thanks for updating to Pigeon!
@cbracken for secondary review.
| wait(for: [called], timeout: 0.5) | ||
| XCTAssertNotNil(panelController.openPanel) | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit: please add the missing final newline.
| await FileSelectorPlatform.instance.getDirectoryPaths( | ||
| confirmButtonText: confirmButtonText, | ||
| ); | ||
| if (directoriesPaths == null) { |
There was a problem hiding this comment.
This is incorrect; it never returns null. It should be checking isEmpty.
|
We've just completed the migration of the plugin code to the flutter/packages repository, as described in https://flutter.dev/go/flutter-plugins-repo-migration, and this repository is now being archived. Unfortunately that means that all in-progress PRs here must be moved to flutter/packages. Please see our instructions for an explanation of how to move your PR, and if you have any issues moving your PR please don't hesitate to reach out in the #hackers-ecosystem channel in Discord. Our apologies that your PR was caught in this one-time transition. We're aware that it's disruptive in the short term, and appreciate your help in getting us to a better long-term state! |
This PR adds the macOS implementation for retrieving multiple directories paths from a select folder dialog.
Issue: Support for the selection of multiple directories, through the desktop's native open panel, in 'file_selector' package
New option on example application
GetDirectoriesPaths
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.