Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

karmactonics
Copy link

When displaying an advertisement using firebase_admob, advertisement may remain displayed if transitioning from a screen displaying a banner advertisement to a screen not displaying.
Specifically, if you call "dispose ()" immediately after "load ()" and "show ()" the ad, it will return by checking contentView and the ad may not be destroyed.

This can be reproduced by creating a screen using Tabbar, tapping Tabbar and quickly transitioning the screen.

Therefore, in order to solve this phenomenon, I send a pull request.
Even if this fix is not approved, I'd like to solve this problem somehow.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@karmactonics
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@collinjackson collinjackson added the submit queue The Flutter team is in the process of landing this PR. label Feb 21, 2019
@cyanglaz cyanglaz changed the title Destroy adView Before contentView Checking [firebase_admob]Destroy adView Before contentView Checking Feb 23, 2019
@isaachjk
Copy link

bump

@collinjackson
Copy link
Contributor

Migrated to firebase/flutterfire#2

collinjackson added a commit to firebase/flutterfire that referenced this pull request Aug 30, 2019
[firebase_admob]Destroy adView Before contentView Checking
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cla: yes flutterfire submit queue The Flutter team is in the process of landing this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants