Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass a URI to package:http API #5202

Merged
merged 2 commits into from
Feb 4, 2021
Merged

Pass a URI to package:http API #5202

merged 2 commits into from
Feb 4, 2021

Conversation

natebosch
Copy link
Contributor

Updates example to be forwards compatible with the breaking change in
dart-lang/http#507

@natebosch
Pass a URI to package:http API
f78c8a6 
Updates example to be forwards compatible with the breaking change in
dart-lang/http#507
@google-cla google-cla bot added the cla: yes Contributor has signed the Contributor License Agreement label Jan 20, 2021
@sfshaza2
Copy link
Contributor

Hi, @natebosch! It's unclear to me. Will this update work now when analyzed against the stable channel? If so, let's go for it. If not, we'll have to wait for this change to hit stable. The website is analyzed against stable. Alternatively, we could document both for now, but annotate the not-yet-working code with the tag which tells Travis to not analyze it.

@natebosch
Copy link
Contributor Author

This will work correctly when analyzed against the current package versions.

The existing published API is statically typed dynamic and at runtime it allows either String or Uri. The upcoming API is statically typed Uri. This PR does not break backwards compatibility, it adds forwards compatibility.

@sfshaza2
Copy link
Contributor

Sounds great!

sfshaza2
sfshaza2 approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfshaza2
Copy link
Contributor

sfshaza2 commented Feb 4, 2021

@RedBrogdon fixed the cookbook code check errors in another PR. Forcing a merge.

@sfshaza2 sfshaza2 merged commit 7860c41 into flutter:master Feb 4, 2021
filiph pushed a commit to filiph/website that referenced this pull request Feb 22, 2021
@natebosch @filiph
Pass a URI to package:http API (flutter#5202)
a369084 
* Pass a URI to package:http API

Updates example to be forwards compatible with the breaking change in
dart-lang/http#507

* Other usages. Drop local variable type to match other example
@jamesderlin jamesderlin mentioned this pull request May 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfshaza2 sfshaza2 sfshaza2 approved these changes

Assignees
No one assigned
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natebosch @sfshaza2